Skip to content

Properly validate DNS subdomains in MatchBaseName. #9620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kareem-wolfssl wants to merge 1 commit into from
+4 −0
Closed

Properly validate DNS subdomains in MatchBaseName. #9620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions wolfcrypt/src/asn.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19373,6 +19373,10 @@ static int MatchBaseName(int type, const char* name, int nameSz,
* host1.example.com does not. */
if (type == ASN_DNS_TYPE || (type == ASN_RFC822_TYPE && base[0] == '.')) {
int szAdjust = nameSz - baseSz;
if (szAdjust > 0) {
if (name[szAdjust-1] != '.')
return 0;
}
name += szAdjust;
nameSz -= szAdjust;
}
Expand Down
Loading