Add CRL generation code #9631
Draft
Add CRL generation code #9631
+1,880
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 11 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/api.c
Outdated
| ExpectNotNull(wolfSSL_X509_CRL_set_nextUpdate(crl, &asnTime)); | ||
|
|
||
| /* Add revoked certificates based on serial numbers */ | ||
| for (int i = 0; i < numSerials; i++) { |
There was a problem hiding this comment.
C89 compliance issue: Variable 'i' is declared in the for loop initialization. This is a C99 feature that may not be compatible with C89 compilers. The variable should be declared before the for loop if C89 compatibility is required.
padelsbach
force-pushed
the
crl-generation
branch
12 times, most recently
from
b386dbf to
728e99c
Compare
padelsbach
force-pushed
the
crl-generation
branch
from
728e99c to
ccd3562
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ability to generate a certificate revocation list (CRL), in addition to the existing CRL decode logic.
Testing
New unit test in C, and new test script which uses openssl to validate the output.
Checklist