20260108-DEFAULT_MAX_CLASSIC_ASYM_KEY_BITS #9633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douzzer
force-pushed
the
20260108-DEFAULT_MAX_CLASSIC_ASYM_KEY_BITS
branch
from
d316788 to
d4840d8
Compare
Contributor
Author
|
retest this please |
embhorn
previously approved these changes
Jan 21, 2026
dgarske
approved these changes
Jan 21, 2026
dgarske
requested changes
Jan 21, 2026
Contributor
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
This does not look right. Its just changing the default minimum RSA/DH from 3072 -> 4096 bit for SP math all (sp_int.c). The issue referenced was fast math tfm.c and its adjusted with FP_MAX_BITS (2 * max). The customer/user should supply that during build to determine actual maximum size they want to support.
…don't add WOLFSSL_X86_64_BUILD to AM_CFLAGS; fix handling for --enable-bump; wolfssl/wolfcrypt/settings.h: classify OPENSSL_EXTRA as "desktop type system" in bump up of default FP_MAX_BITS and SP_INT_BITS; wolfssl/wolfcrypt/types.h: if WC_32BIT_CPU, don't define WC_64BIT_CPU.
douzzer
force-pushed
the
20260108-DEFAULT_MAX_CLASSIC_ASYM_KEY_BITS
branch
from
d4840d8 to
142f493
Compare
dgarske
approved these changes
Jan 22, 2026
Contributor
Author
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configure.ac: ifENABLED_32BIT, add-DWC_32BIT_CPUtoAM_CFLAGS, and don't addWOLFSSL_X86_64_BUILDtoAM_CFLAGS; fix handling for--enable-bump;wolfssl/wolfcrypt/settings.h: classifyOPENSSL_EXTRAas "desktop type system" in bump up of defaultFP_MAX_BITSandSP_INT_BITS;wolfssl/wolfcrypt/types.h: ifWC_32BIT_CPU, don't defineWC_64BIT_CPU.fixes #7929 when combined with
--enable-opensslextra.tested with
wolfssl-multi-test.sh ... check-configure cross-powerpc32-asm-ocsp-test, the latter of which runs the reproducer in #7929 on emulated-ppc32 using some new logic I've just added to multi-test.also tested with
wolfssl-multi-test.sh ... '.*-m32.*'