Fix OpenSSL error code handling in ERR_reason_error_string() #9635
+82
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
retest this please |
miyazakh
force-pushed
the
x509errstr_handling
branch
from
d1ed2c3 to
942c6ce
Compare
miyazakh
force-pushed
the
x509errstr_handling
branch
from
942c6ce to
0e8af03
Compare
Contributor
Author
|
retest this please
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Error codes from
2to8are converted incorrectly. To avoid this, check the OpenSSL X509 error codes first when the value is positive. If no match is found, fall back to the wolfSSL error codes.Issue#9086
Testing
Run unit test
Checklist