Thumb2 SP ASM: mont_sub fix #9767
Open
+38
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Code generated by PR: |
bigbrett
approved these changes
Feb 13, 2026
Contributor
bigbrett
left a comment
bigbrett
left a comment
There was a problem hiding this comment.
confirmed fix works on CM3 hardware
Always use all the parameters and always use the parameter name and not the assumed register.
SparkiDev
force-pushed
the
sp_thumb2_mont_sub_reg_fix
branch
from
8910cae to
e48c867
Compare
Contributor
Author
|
rebased to master |
Contributor
Author
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Always use all the parameters and always use the parameter name and not the assumed register.
Testing
How did you test?
Checklist