Remove workaround for elm-codegen improperly qualifying names #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniBill
force-pushed
the
qualify
branch
3 times, most recently
from
d8c5a12 to
7671a68
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
|
wolfadex
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qualifywas needed to avoid referring toFoo.xwhile inside moduleFoo.elm-codegennow does this automatically.Draft because I want to make sure the diff is empty before unleashing
elm-reviewon it and removing all the unused parameters.