fix: logging started getting pretty noisy#1419
Merged
luhring merged 3 commits intowolfi-dev:mainfrom Jan 27, 2025
Merged
Conversation
Logging for at least some commands used to default to WARN level. We recently cleaned up logging, but according to git bisect, commit d2196cd has commands like "scan" logging at INFO by default, which is noisier than intended for the commands. This change sets the default logging level to WARN while preserving the ability to set it to INFO or higher if desired. Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
Updated to latest on main (v0.23.1-0.20250125200830-0b6b8a0543aa) to pick up logging noise improvements from chainguard-dev/apko#1497. Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
imjasonh
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For multiple reasons, the log output shown to users by default started creeping up over time. This PR gets the default logging back to a healthy minimum (while still configurable to any crazy amount, of course!).
Before
Now