Fixed memory leak when assessing file permissions in qhash.c#117
Merged
wolkykim merged 1 commit intowolkykim:mainfrom Dec 15, 2025
Merged
Fixed memory leak when assessing file permissions in qhash.c#117wolkykim merged 1 commit intowolkykim:mainfrom
wolkykim merged 1 commit intowolkykim:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of qhashmd5_file(...) fails to close an open file descriptor upon a failed call to fstat(...). While it's unlikely to occur as the file has just been opened, it's still good practice to clean up all allocated resources in the event of a failure.
This is my first commit to this repository. I do not see a commit style guide or commit guidelines. If I missed these guides, please let me know!