This repository was archived by the owner on May 20, 2025. It is now read-only.
bounty: fix slot overwrite bug on packed variables#117
Draft
wei3erHase wants to merge 1 commit intowonderland-archive:mainfrom
Draft
bounty: fix slot overwrite bug on packed variables#117wei3erHase wants to merge 1 commit intowonderland-archive:mainfrom
wei3erHase wants to merge 1 commit intowonderland-archive:mainfrom
Conversation
This was referenced Jun 17, 2022
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug description:
When variables are declared nearby (sometimes either in other abstract contract, but close on declaration order), using the
setVariablemethod on one, can erase the information about the other variable.Given that
myAddress(that occupies ~uint160) andmyBoolare stored together, the secondsetVariablemethod aims to the entire data slot and overwrites it with0x0000...1(true), and when themyAddressslot is fetched, is filled with0s.An example contract is added, and a test replicating the descripted bug.