This repository was archived by the owner on May 20, 2025. It is now read-only.
fix: explicitly add web3-utils dependency#191
Open
ThunderDeliverer wants to merge 2 commits intowonderland-archive:devfrom
Open
fix: explicitly add web3-utils dependency#191ThunderDeliverer wants to merge 2 commits intowonderland-archive:devfrom
ThunderDeliverer wants to merge 2 commits intowonderland-archive:devfrom
Conversation
Testing with Smock failed due to the missing web3-utils dependency. The dependecy is now explicitly added to the package.json file.
wei3erHase
reviewed
Sep 5, 2023
package.json
Outdated
| "typechain": "5.1.1", | ||
| "typescript": "4.5.2" | ||
| "typescript": "4.5.2", | ||
| "web3-utils": "^4.0.5" |
Author
There was a problem hiding this comment.
Sure 😁
Should be ok now ✅
Contributor
There was a problem hiding this comment.
getting this error on gh tests, any clue?
error @noble/hashes@1.3.1: The engine "node" is incompatible with this module. Expected version ">= 16". Got "14.21.3"
Author
There was a problem hiding this comment.
Huh, let me try them locally
Author
There was a problem hiding this comment.
I'm getting no issues on my end (I'm using yarn 1.22.19 and node v16.15.0)
wei3erHase
previously approved these changes
Sep 10, 2023
Contributor
wei3erHase
left a comment
wei3erHase
left a comment
There was a problem hiding this comment.
lgtm! @0xGorilla wdyt?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing with Smock failed due to the missing web3-utils dependency.
The dependency is now explicitly added to the package.json file.
Metadata