Skip to content

Tailor content for service-based merchants#3265

Merged
joemcgill merged 17 commits intofeature/GOOWOO-337-serviced-based-merchantsfrom
add/GOOWOO-476-update-copy-for-sbm
Mar 3, 2026
Merged

Tailor content for service-based merchants#3265
joemcgill merged 17 commits intofeature/GOOWOO-337-serviced-based-merchantsfrom
add/GOOWOO-476-update-copy-for-sbm

Conversation

@asvinb
Copy link
Collaborator

@asvinb asvinb commented Feb 24, 2026

Changes proposed in this Pull Request:

Closes https://linear.app/a8c/issue/GOOWOO-476/update-copy-for-sbm

Replace this with a good description of your changes & reasoning.

Screenshots:

Detailed test instructions:

  1. The copy should be updated on the onboarding flow for service based merchants.

Additional details:

Changelog entry

@github-actions github-actions bot added type: enhancement The issue is a request for an enhancement. changelog: add A new feature, function, or functionality was added. labels Feb 24, 2026
@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 3.84615% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.1%. Comparing base (e20bc39) to head (17b10b9).

Files with missing lines Patch % Lines
...paid-ads/ads-campaign/paid-ads-features-section.js 0.0% 5 Missing and 1 partial ⚠️
js/src/components/paid-ads/asset-group/faqs.js 0.0% 5 Missing and 1 partial ⚠️
...paid-ads/campaign-preview/campaign-preview-card.js 0.0% 4 Missing and 1 partial ⚠️
...c/components/paid-ads/ads-campaign/ads-campaign.js 0.0% 3 Missing and 1 partial ⚠️
js/src/components/paid-ads/ads-campaign/faqs.js 0.0% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                               Coverage Diff                                @@
##             feature/GOOWOO-337-serviced-based-merchants   #3265      +/-   ##
================================================================================
- Coverage                                           67.0%   66.1%    -0.8%     
================================================================================
  Files                                                884     374     -510     
  Lines                                              26619    6115   -20504     
  Branches                                            1541    1551      +10     
================================================================================
- Hits                                               17831    4045   -13786     
+ Misses                                              8593    1870    -6723     
- Partials                                             195     200       +5     
Flag Coverage Δ
js-unit-tests 66.1% <3.8%> (-0.3%) ⬇️
php-unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...set-group/asset-group-header/asset-group-header.js 90.0% <100.0%> (ø)
...c/components/paid-ads/ads-campaign/ads-campaign.js 0.0% <0.0%> (ø)
js/src/components/paid-ads/ads-campaign/faqs.js 16.7% <0.0%> (-50.0%) ⬇️
...paid-ads/campaign-preview/campaign-preview-card.js 0.0% <0.0%> (ø)
...paid-ads/ads-campaign/paid-ads-features-section.js 0.0% <0.0%> (ø)
js/src/components/paid-ads/asset-group/faqs.js 12.5% <0.0%> (-54.2%) ⬇️

... and 510 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ankitguptaindia
Copy link
Collaborator

Hi @asvinb thanks for the changes, it works as scoped. However, on some places I can see the term "Product", please check if this is also in scope? Thanks!

Needs Feedback:

On the first screen of the plugin setup, there is some reference related to “Product.” Was there any discussion about this, or is it intentional?

Recording.1722.mp4
Screenshot 2026-02-26 at 6 16 43 PM Screenshot 2026-02-26 at 6 40 58 PM

Copy Text Updated ✅

Discussion from this thread has been addressed: ✅
https://docs.google.com/document/d/1lGJSh-S4b9lEOYpaY_EACWPZVlQwAJNUcMgbhda_FRw/edit?resourcekey=0-lzRoHC46-2_XYvsOsfi2Ew&disco=AAABzbu7k7c

Screenshot 2026-02-26 at 6 11 56 PM

Discussion from this thread has been addressed: ✅
https://docs.google.com/document/d/1lGJSh-S4b9lEOYpaY_EACWPZVlQwAJNUcMgbhda_FRw/edit?resourcekey=0-lzRoHC46-2_XYvsOsfi2Ew&disco=AAAB0k_n6ZM

Screenshot 2026-02-26 at 6 11 36 PM

Discussion from this thread has been addressed.: ✅
https://docs.google.com/document/d/1lGJSh-S4b9lEOYpaY_EACWPZVlQwAJNUcMgbhda_FRw/edit?resourcekey=0-lzRoHC46-2_XYvsOsfi2Ew&disco=AAABzoksKMg

Screenshot 2026-02-26 at 6 18 09 PM

Discussion from this thread has been addressed: ✅
https://docs.google.com/document/d/1lGJSh-S4b9lEOYpaY_EACWPZVlQwAJNUcMgbhda_FRw/edit?resourcekey=0-lzRoHC46-2_XYvsOsfi2Ew&disco=AAABzoksKMc
Screenshot 2026-02-26 at 6 23 04 PM

Copy link
Collaborator

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asvinb this looks pretty good. Just a couple bits of feedback.

@joemcgill joemcgill merged commit c430b9e into feature/GOOWOO-337-serviced-based-merchants Mar 3, 2026
7 checks passed
@joemcgill joemcgill deleted the add/GOOWOO-476-update-copy-for-sbm branch March 3, 2026 18:05
@joemcgill joemcgill added changelog: none Skip changelog entry for this PR and removed type: enhancement The issue is a request for an enhancement. changelog: add A new feature, function, or functionality was added. labels Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: none Skip changelog entry for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants