Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3298 +/- ##
============================================
+ Coverage 66.1% 66.6% +0.4%
- Complexity 0 5247 +5247
============================================
Files 374 890 +516
Lines 6115 26923 +20808
Branches 1551 1551
============================================
+ Hits 4045 17922 +13877
- Misses 1870 8801 +6931
Partials 200 200
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR provides a path for service-based merchants to connect their Merchant Center account after they have set up at least 1 physical product.
Closes GOOWOO-516: Surface MC setup for transitioned service-based merchants
Specifically, a new
ServiceBasedMerchantHooksclass listens for product lifecycle events and resets the cachedIS_SERVICE_BASED_MERCHANToption so it is recalculated on the next admin page load:Moreover, a new
ConnectMerchantCenterCardcomponent was added in the Linked Accounts section of the Settings page.It renders when:
serviceBasedMerchantisfalse(merchant now has physical products), andThe card uses the existing MC account card appearance and links to the
/google/setup-mconboarding wizard, which will show the full MC + Ads stepper since the merchant is no longer service-based.Once
serviceBasedMerchantflips back totrue(all physical products removed) or MC is connected, the card hides automatically.Screenshots:
Detailed test instructions:
Changelog entry