Skip to content

Fix/GOOWOO-526: Channel visibility event name change#3312

Merged
asvinb merged 1 commit intofeature/in-product-placementsfrom
fix/GOOWOO-526-campaign-track-event
Mar 19, 2026
Merged

Fix/GOOWOO-526: Channel visibility event name change#3312
asvinb merged 1 commit intofeature/in-product-placementsfrom
fix/GOOWOO-526-campaign-track-event

Conversation

@AlejandroPerezMartin
Copy link
Collaborator

Changes proposed in this Pull Request:

Closes https://linear.app/a8c/issue/GOOWOO-526/get-started-event-through-create-campaign-click-after-clicking-dismiss

Replaces the gla_google_ads_promo_create_campaign_click event in the Get started button within the channel visibility box with the event gla_google_ads_promo_get_started_click

Screenshots:

Screenshot 2026-03-18 at 7 39 46 PM

Detailed test instructions:

  1. Clicking the "Get started" button in the channel visibility box should send the wcadmin_gla_google_ads_promo_get_started_click event

Additional details:

Changelog entry

@AlejandroPerezMartin AlejandroPerezMartin self-assigned this Mar 19, 2026
@AlejandroPerezMartin AlejandroPerezMartin changed the base branch from develop to feature/in-product-placements March 19, 2026 11:03
@github-actions github-actions bot added type: bug The issue is a confirmed bug. changelog: fix Took care of something that wasn't working. labels Mar 19, 2026
@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.2%. Comparing base (1ea106d) to head (e16dd18).
⚠️ Report is 2 commits behind head on feature/in-product-placements.

Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                       @@
##             feature/in-product-placements   #3312   +/-   ##
===============================================================
  Coverage                             66.2%   66.2%           
  Complexity                            5429    5429           
===============================================================
  Files                                  909     909           
  Lines                                28060   28060           
  Branches                              1660    1660           
===============================================================
  Hits                                 18573   18573           
  Misses                                9246    9246           
  Partials                               241     241           
Flag Coverage Δ
js-unit-tests 64.2% <ø> (ø)
php-unit-tests 66.8% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asvinb asvinb merged commit 9689b2f into feature/in-product-placements Mar 19, 2026
17 checks passed
@asvinb asvinb deleted the fix/GOOWOO-526-campaign-track-event branch March 19, 2026 13:52
@ankitguptaindia
Copy link
Collaborator

QA Status: Approved ✅

Screenshot 2026-03-19 at 9 18 47 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants