Open
Conversation
jonathansadowski
requested review from
a team,
psealock and
samueljseay
and removed request for
a team and
psealock
samueljseay
approved these changes
Sep 27, 2022
Contributor
samueljseay
left a comment
samueljseay
left a comment
There was a problem hiding this comment.
This is looking good to me and a low-cost addition to have this check. Thanks for doing this work! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR introduces a GitHub workflow to run PHPCS checks in CI on Push event. This is interesting to have, as PHPCS tests the PHP compatibility with the minimum PHP version required by the project.
How to test the changes in this Pull Request:
Changelog entry
FOR PR REVIEWER ONLY: