Companies without personal details and only allowed countries#107
Open
michi-dev wants to merge 4 commits intowoocommerce:trunkfrom
Open
Companies without personal details and only allowed countries#107michi-dev wants to merge 4 commits intowoocommerce:trunkfrom
michi-dev wants to merge 4 commits intowoocommerce:trunkfrom
Conversation
Contributor
|
@coreymckrill any option to check and include this next? |
Contributor
|
@masteradhoc it's going to be a while before I have time for another round of improvements, but I agree that this should get reviewed soon. |
rrennick
suggested changes
Mar 16, 2023
| default: | ||
| break; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
@masteradhoc While it may be a bit before we get to review this, the added code isn't formatted according to WP Coding Standards which we would need before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Closes #108 and #66
How to test the changes in this Pull Request:
wp wc generate customers 10to generate 10 customers/wp-admin/edit.php?post_type=shop_order ordersfor ordersfeature #108
In 3/4 cases there is a business involved with an order. It can be shipping, billing, or both. If there is a business involved, there will be a 1/2 chance that the address will be assigned to only the business. The other 1/2 would be that the address will be assigned to a business with a person. That means that the fields firstname and lastname will be filled out.
with billing / shipping addresses wich do have a business (the field
companywith a value) but do not have personal details (firstnameandlastnameempty)feature #66
There is the woocommerce option
woocommerce_allowed_countries, which can be set in the page/wp-admin/admin.php?page=wc-settingsto three different options:every option has its own logic added to the pull request.
Other information:
Changelog entry
FOR PR REVIEWER ONLY: