[WOOMOB-1980] Add Learn more CTA to Mobile Announcements #15272
+666
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staskus
added
type: enhancement
Collaborator
Generated by 🚫 Danger |
Collaborator
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
staskus
changed the title
Collaborator
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...rce/src/main/kotlin/com/woocommerce/android/ui/whatsnew/FeatureAnnouncementDialogFragment.kt
Fixed
Show fixed
Hide fixed
...mmerce/src/main/kotlin/com/woocommerce/android/ui/whatsnew/FeatureAnnouncementListAdapter.kt
Fixed
Show fixed
Hide fixed
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #15272 +/- ##
=========================================
Coverage 38.81% 38.82%
- Complexity 10667 10669 +2
=========================================
Files 2205 2205
Lines 125374 125407 +33
Branches 17394 17397 +3
=========================================
+ Hits 48670 48683 +13
- Misses 71759 71780 +21
+ Partials 4945 4944 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add database support for storing the detailsUrl field in WhatsNewAnnouncementEntity to ensure cached announcements display Learn more links consistently across all entry points.
Remove feature-level detailsUrl since the API only provides a single URL at the announcement level. The UI now shows two states: - With detailsUrl: "Learn more" primary CTA + "Not now" secondary - Without detailsUrl: "Continue" primary CTA only
- Mark announcement as viewed and close dialog when Learn more is tapped - Make detailsUrl nullable in API response to handle missing field - Add logging when URL fails to open
staskus
commented
Feb 3, 2026
| val imageData: ByteArray | ||
| try { | ||
| val sanitizedBase64String = base64ImageData.replace("data:image/png;base64,", "") | ||
| val sanitizedBase64String = base64ImageData.replace(Regex("^data:image/[^;]+;base64,"), "") |
Contributor
Author
There was a problem hiding this comment.
According to Claude:
The original code only stripped the PNG data URI prefix. But base64 image data can come with different MIME types:
- data:image/png;base64,
- data:image/jpeg;base64,
- data:image/gif;base64,
- data:image/webp;base64,
- data:image/svg+xml;base64,
The regex ^data:image/[^;]+;base64, matches:
- ^data:image/ — starts with "data:image/"
- [^;]+ — one or more characters that are NOT a semicolon (captures the image type)
- ;base64, — followed by ";base64,"
This makes the code more robust—if the API returns a JPEG or any other image format, it will be handled correctly instead of
failing to decode because the prefix wasn't stripped.
Contributor
Author
|
@kidinov @malinajirka not urgent, one review is enough. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context: pdfdoF-8Ff-p2
iOS PR: woocommerce/woocommerce-ios#16591
WOOMOB-1980
Mobile announcements tool supports passing a learn more URL. However, it is not used in the app. Add optional "Learn more" link support for What's New feature announcements with two display states:
Announcement Display States
detailsUrlprovideddetailsUrlprovidedFor easier testing:
Testing
Live Test via Developer Options
Ensure test announcement is enabled:
APP VERSION = 999.0and forWoo Androidis enabled (Wait a minute or two after enabling, disable after testing)Fetch and display the announcement:
Screenshots & Videos
No announcement link
With announcement link
announcement.android.mov
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.