Skip to content

Allow displaying PN for non WP users#15279

Open
irfano wants to merge 3 commits intotrunkfrom
issue/WOOMOB-2113-update-logged-in-state-logic-for-pn
Open

Allow displaying PN for non WP users#15279
irfano wants to merge 3 commits intotrunkfrom
issue/WOOMOB-2113-update-logged-in-state-logic-for-pn

Conversation

@irfano
Copy link
Contributor

@irfano irfano commented Feb 2, 2026

Description

In the Woo Push Notifications project, we allow users who are using self-hosted sites without a WP.com login to receive push notifications. Previously, we had a check that prevented displaying notifications if users were not logged in. Now, for Woo-driven notifications, we skip this check and instead verify that the notification's site is still visible before displaying it.

Test Steps

Testing isn’t currently possible because the Woo push server isn’t active yet.

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@irfano irfano added this to the 24.1 milestone Feb 2, 2026
@irfano irfano requested a review from JorgeMucientes February 2, 2026 13:13
@irfano irfano added feature: notifications Related to notifications or notifs. Task (new) labels Feb 2, 2026
@irfano irfano force-pushed the issue/WOOMOB-2113-update-logged-in-state-logic-for-pn branch from 433fc8d to 53e338c Compare February 2, 2026 13:14
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 2, 2026

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit68910d5
Direct Downloadwoocommerce-wear-prototype-build-pr15279-68910d5.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 2, 2026

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit68910d5
Direct Downloadwoocommerce-prototype-build-pr15279-68910d5.apk

@irfano irfano force-pushed the issue/WOOMOB-2113-update-logged-in-state-logic-for-pn branch from 53e338c to 68910d5 Compare February 2, 2026 13:55
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.76%. Comparing base (52db21d) to head (68910d5).
⚠️ Report is 10 commits behind head on trunk.

Files with missing lines Patch % Lines
...d/notifications/push/NotificationMessageHandler.kt 57.14% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #15279      +/-   ##
============================================
- Coverage     38.76%   38.76%   -0.01%     
  Complexity    10671    10671              
============================================
  Files          2207     2207              
  Lines        125597   125601       +4     
  Branches      17379    17380       +1     
============================================
+ Hits          48690    48691       +1     
- Misses        71968    71971       +3     
  Partials       4939     4939              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wpmobilebot wpmobilebot modified the milestones: 24.1, 24.2 Feb 6, 2026
@wpmobilebot
Copy link
Collaborator

Version 24.1 has now entered code-freeze, so the milestone of this PR has been updated to 24.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: notifications Related to notifications or notifs. Task (new)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants