Open
Conversation
433fc8d to
53e338c
Compare
Collaborator
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
Collaborator
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
53e338c to
68910d5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #15279 +/- ##
============================================
- Coverage 38.76% 38.76% -0.01%
Complexity 10671 10671
============================================
Files 2207 2207
Lines 125597 125601 +4
Branches 17379 17380 +1
============================================
+ Hits 48690 48691 +1
- Misses 71968 71971 +3
Partials 4939 4939 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the Woo Push Notifications project, we allow users who are using self-hosted sites without a WP.com login to receive push notifications. Previously, we had a check that prevented displaying notifications if users were not logged in. Now, for Woo-driven notifications, we skip this check and instead verify that the notification's site is still visible before displaying it.
Test Steps
Testing isn’t currently possible because the Woo push server isn’t active yet.
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.