Conversation
Add a Jest setupFilesAfterEnv file that stubs HTMLFormElement.prototype.submit to suppress jsdom "Not implemented" console errors across all test suites. Remove per-test form.submit spy overrides that are no longer needed. Closes WOOSUBS-1522
luizreis
force-pushed
the
woosubs-1522-woofraudprotection-js-tests-emit-jsdom-not-implemented
branch
from
615fc93 to
fc59286
Compare
luizreis
deleted the
woosubs-1522-woofraudprotection-js-tests-emit-jsdom-not-implemented
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
setupFilesAfterEnvfile (tests/js/setup.js) that stubsHTMLFormElement.prototype.submitinbeforeEach, suppressing jsdom "Not implemented" console errors across all JS test suitesform.submitspy overrides inadd-payment-method.test.js,pay-for-order.test.js, andshortcode-checkout.test.js, asserting directly on the globally-stubbedform.submitinsteadCloses WOOSUBS-1522
How to test the changes in this Pull Request
npm run test:jspasses with no console errors.