Fix Optimized Checkout note generating an E_ERROR when the new checkout is disabled (#4594)

* Add fallback is_oc_enabled() implementation to the base gateway
* Fix endless re-render in the settings page

Author: diegocurbelo

changelog.txt

@@ -12,6 +12,7 @@
 * Fix - Remove connection type requirement from PMC sync migration attempt
 * Tweak - Small improvements to e2e tests
 * Fix - Prevent the PMC migration to run when the plugin is not connected to Stripe
+* Fix - Fixes a fatal error in the OC inbox note when the new checkout is disabled
 
 = 9.8.0 - 2025-08-11 =
 * Add - Adds the current setting value for the Optimized Checkout to the Stripe System Status Report data

includes/admin/class-wc-stripe-settings-controller.php

@@ -278,7 +278,7 @@ public function admin_scripts( $hook_suffix ) {
 			'account_country'                       => $this->account->get_account_country(),
 			'are_apms_deprecated'                   => WC_Stripe_Feature_Flags::are_apms_deprecated(),
 			'is_amazon_pay_available'               => WC_Stripe_Feature_Flags::is_amazon_pay_available(),
-			'is_oc_available'                       => WC_Stripe_Feature_Flags::is_oc_available(),
+			'is_oc_available'                       => WC_Stripe_Feature_Flags::is_oc_available() && WC_Stripe_Feature_Flags::is_upe_checkout_enabled(),
 			'is_oc_enabled'                         => $is_oc_enabled,
 			'oauth_nonce'                           => wp_create_nonce( 'wc_stripe_get_oauth_urls' ),
 			'is_sepa_tokens_enabled'                => 'yes' === $this->gateway->get_option( 'sepa_tokens_for_other_methods', 'no' ),

includes/class-wc-gateway-stripe.php

@@ -1230,4 +1230,17 @@ private function validate_field( $field_key, $field_value ) {
 	public function is_payment_request_enabled() {
 		return 'yes' === $this->get_option( 'payment_request' );
 	}
+
+	/**
+	 * Checks if the Optimized Checkout setting is enabled.
+	 *
+	 * OC is not supported in the legacy gateway, so we return false here,
+	 * this method is then overridden by UPE payment gateway which extends from this class.
+	 *
+	 * @return bool Always false.
+	 */
+	public function is_oc_enabled() {
+		// Always return false here, as OC is not supported in the legacy gateway.
+		return false;
+	}
 }

readme.txt

@@ -122,5 +122,6 @@ If you get stuck, you can ask for help in the [Plugin Forum](https://wordpress.o
 * Fix - Remove connection type requirement from PMC sync migration attempt
 * Tweak - Small improvements to e2e tests
 * Fix - Prevent the PMC migration to run when the plugin is not connected to Stripe
+* Fix - Fixes a fatal error in the OC inbox note when the new checkout is disabled
 
 [See changelog for full details across versions](https://raw.githubusercontent.com/woocommerce/woocommerce-gateway-stripe/trunk/changelog.txt).