Skip to content

Add notices for active and repeated rate limiting #4329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

daledupreez
Copy link
Contributor

Fixes STRIPE-<linear_issue_id>
Fixes #<github_issue_id>

Changes proposed in this Pull Request:

This PR builds on #4327 and adds notices based on the data that we're tracking for rate limiting. In particular, it shows a notice for the following cases:

  • When API calls are currently rate limited
  • When there have been 3 or more periods of rate limiting in the last hour
  • When there have been 5 or more periods of rate limiting in the last 24 hours

None of the notices are dismissible. It may make more sense for the repeated ones to be dismissible, especially the 24 hour one, as users may resolve the issue.

There are still some outstanding issues:

  • The wording and CTA for the notices is very much a first draft -- what should we ask users to do if their site is being rate limited?
  • I picked the timing for these options without thinking about it too much. We should consider what they look like.
  • Should we include the repeated notices in this first pass?
  • Should we also trigger emails when we trigger rate limiting? This feels like it should be a future improvement.

Testing instructions


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant