Skip to content

Conversation

wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Aug 7, 2025

Changes proposed in this Pull Request:

This is a simple PR that introduces a new helper method (is_stripe_gateway_order) to identify Stripe-gateway orders, replacing some duplicate code.

Testing instructions

Code review. Check if the tests are still passing.


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

Base automatically changed from fix/checking-for-the-subscription-detached-payment-method to develop August 8, 2025 14:13
@wjrosa wjrosa self-assigned this Aug 13, 2025
@wjrosa wjrosa marked this pull request as ready for review August 20, 2025 08:44
@wjrosa wjrosa requested review from a team, diegocurbelo and Mayisha and removed request for a team August 20, 2025 08:45
@wjrosa wjrosa requested a review from Mayisha August 20, 2025 15:48
Copy link
Member

@diegocurbelo diegocurbelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Mayisha Mayisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@wjrosa wjrosa enabled auto-merge (squash) August 20, 2025 17:38
@wjrosa wjrosa merged commit acdb6e1 into develop Aug 20, 2025
40 checks passed
@wjrosa wjrosa deleted the dev/helper-method-to-check-for-an-order-gateway branch August 20, 2025 19:29
@wjrosa wjrosa added this to the 9.9.0 milestone Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants