Removing card requirement for OC

[wjrosa]

Fixes STRIPE-646

Changes proposed in this Pull Request:

In this PR I am removing the requirement for the credit card payment method when the Optimized Checkout is enabled. This way, merchants are allowed to use the feature with any payment method setup they want, without having to force CCs.

Testing instructions

• Checkout to this branch on your test environment (fix/removing-card-requirement-for-oc)
• Connect your Stripe account
• Enable the Optimized Checkout
• Disable the credit card payment method
• Enable any other payment method(s)
• As a shopper, add a product to your cart
• Go to the checkout page
• Confirm the OC container is rendered, showing the enabled payment methods inside of it
• Confirm you are able to complete the purchase

---

• Covered with tests (or have a good reason not to test in description ☝️)
• Tested on mobile (or does not apply)

Changelog entry

• This Pull Request does not require a changelog entry. (Comment required below)

Changelog Entry Comment

Comment

Post merge

• Added testing instructions to the Release Testing Instructions wiki page (or does not apply)
• Added the needs docs label (or does not apply)
• Included this PR in the Release Thread scope (or does not apply)

[malithsen]

Edge case: If the merchant disables all payment methods, we show the following error to the shopper

I think we should hide the OC container if all payment methods are disabled.

[wjrosa]

Edge case: If the merchant disables all payment methods, we show the following error to the shopper

I think we should hide the OC container if all payment methods are disabled.

Good catch, @malithsen ! Hiding it in 467aef1

[annemirasol]

Edge case: If the merchant disables all payment methods, we show the following error to the shopper

I think we should hide the OC container if all payment methods are disabled.

Good catch, @malithsen ! Hiding it in 467aef1

This is what I see when there are no enabled payment methods:

[wjrosa]

Edge case: If the merchant disables all payment methods, we show the following error to the shopper

I think we should hide the OC container if all payment methods are disabled.

Good catch, @malithsen ! Hiding it in 467aef1

This is what I see when there are no enabled payment methods:

I saw a merge issue after your latest merge to develop. Fixed it in 44973f1. Any chance that was your issue? I cannot reproduce the error message in your screenshot. This is what I see:

Block checkout

Shortcode checkout

[malithsen]

I get the "no payment methods available" error when all pms are disabled (as expected). Nice work!

However, Link is not presented on this branch, and it seems like the e2e failures are related to this.

[wjrosa]

Thanks, Malith! I have fixed the issue in 4cdbfac. As we spoke on Slack, e2e are passing now for the main suite, but still failing here for the OC ones 👀 (they work locally)

[malithsen]

This looks good to me now! OC test timeouts don't seem related. I tested the flows manually in my local environment and it's working as expected. We should still have a look at those failures and address them in a separate PR.