Skip to content

Conversation

daledupreez
Copy link
Contributor

Changes proposed in this Pull Request:

This PR explores one way of refactoring how we handle the expand[] parameters supported by Stripe's APIs. I am still not sure I like the approach, but it feels better than the mixed implementation that we had before.

One minor concern I have is that the WC_Stripe_API::retrieve() API shape has changed, which might impact code that extends from the plugin, but I think that's not something many (if any) plugins would do due to the methods being called statically using the current class name.

Testing instructions

TBD


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant