Refactor handling of expand[] parameters #4574
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR explores one way of refactoring how we handle the
expand[]
parameters supported by Stripe's APIs. I am still not sure I like the approach, but it feels better than the mixed implementation that we had before.One minor concern I have is that the
WC_Stripe_API::retrieve()
API shape has changed, which might impact code that extends from the plugin, but I think that's not something many (if any) plugins would do due to the methods being called statically using the current class name.Testing instructions
TBD
Changelog entry
Changelog Entry Comment
Comment
Post merge