Fix payment method instructions for OC

[wjrosa]

Fixes STRIPE-665

Changes proposed in this Pull Request:

This simple PR fixes the test payment method instructions not showing up when Optimized Checkout is enabled. When I updated the class name in the CSS file here, I broke the display of the instructions. The fix consists of simply checking if the .content paragraph we want to hide is the correct one (the empty one).

Testing instructions

• Checkout and build this branch on your test environment (fix/payment-method-instructions-for-oc)
• Connect your Stripe account
• Enable the Optimized Checkout feature
• Enable some payment methods with instructions (card, SEPA, etc)
• As a shopper, add a product to your cart
• Go to the block checkout page
• Confirm instructions are correctly shown
• Repeat the test for classic checkout

---

• Covered with tests (or have a good reason not to test in description ☝️)
• Tested on mobile (or does not apply)

Changelog entry

• This Pull Request does not require a changelog entry. (Comment required below)

Changelog Entry Comment

Comment

Post merge

• Added testing instructions to the Release Testing Instructions wiki page (or does not apply)
• Added the needs docs label (or does not apply)
• Included this PR in the Release Thread scope (or does not apply)

[malithsen]

I see the test instructions for some payment methods like SEPA. But for Cards, instructions show up for a second when the page is loading and then getsdisplay: none-ed

[wjrosa]

@malithsen that's strange. I just tested it again, both shortcode and blocks, and it works just fine for me 🤔 . Did you try to rebuild the frontend files? And clear the cache for the browser?

[annemirasol]

I see test instructions for card, but not SEPA.

Split PE:

OC:

Same behavior for both block and classic checkout.

[annemirasol]

I see test instructions for card, but not SEPA.

NVM, I see it above the payment methods!

[annemirasol]

Works as described for me!

[malithsen]

that's strange. I just tested it again, both shortcode and blocks, and it works just fine for me 🤔 . Did you try to rebuild the frontend files? And clear the cache for the browser?

@wjrosa I still have the issue. I noticed that it only happens when I am testing as a logged in customer. For guest users, test instructions show up as expected.

[wjrosa]

@malithsen can you rebuild, clear your cache, and try again, please? I did fix the display: none issue, and maybe that's what was causing your bug somehow (it still works fine for me).

[malithsen]

can you rebuild, clear your cache, and try again, please?

After rebuilding and clearing cache I was still seeing it. I then uploaded a build of this branch to a JN site, and test instructions show up as expected for both logged-in and guest users, so as you said, this is likely a caching issue on my local setup.