-
Notifications
You must be signed in to change notification settings - Fork 216
Moving OC card method logic to the new OC payment method class #4579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: fix/removing-card-requirement-for-oc
Are you sure you want to change the base?
Moving OC card method logic to the new OC payment method class #4579
Conversation
…c-card-method-logic-to-single-method-class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wjrosa I am getting some errors when testing this branch.
Settings
✅ Settings page looks good.
Shortcode checkout
✅ Single payment element is displayed on the checkout page.
🔴 Checkout fails for me with the following error-

And I see this in my logs

Block checkout

🔴 Checkout fails with the following error-

…c-card-method-logic-to-single-method-class
…c-card-method-logic-to-single-method-class
…c-card-method-logic-to-single-method-class
Fixes STRIPE-667
Changes proposed in this Pull Request:
This PR moves all the specific Optimized Checkout logic of the card payment method to a new payment method class. The goal is to improve the code's organization and properly separate its concerns.
Testing instructions
dev/moving-oc-card-method-logic-to-single-method-class
)Changelog entry
Changelog Entry Comment
Comment
Post merge