Revert viewModel and tests to previous implementation

We decided to keep the previous implementation (show only the manuals that the store supports) rather than show all manuals for all stores. This commit reverts the changes and deals with the new Manual object being optional by using compactMap rather than map

Author: iamgabrielma

WooCommerce/Classes/ViewRelated/Dashboard/Settings/In-Person Payments/CardReaderManualsViewModel.swift

@@ -9,10 +9,13 @@ struct Manual: Identifiable, Equatable {
 }
 
 final class CardReaderManualsViewModel {
+    var configurationLoader: CardPresentConfigurationLoader
     let manuals: [Manual]
 
     init() {
-        // Display all card readers at all times. Ref: pdfdoF-1aF-p2
-        self.manuals = CardReaderType.allCases.compactMap { $0.manual }
+        // Initialize the ViewModel only with the supported readers for the specific store's country
+        self.configurationLoader = CardPresentConfigurationLoader()
+        let supportedReaders = configurationLoader.configuration.supportedReaders
+        self.manuals = supportedReaders.compactMap { $0.manual }
     }
 }

WooCommerce/WooCommerceTests/ViewRelated/CardPresentPayments/CardReaderManualsViewModelTests.swift

@@ -7,7 +7,6 @@ class CardReaderManualsViewModelTests: XCTestCase {
     private var storageManager: MockStorageManager!
     private var stores: MockStoresManager!
     private let sampleSiteID: Int64 = 1234
-    private let availableReaderTypes = [CardReaderType.chipper, CardReaderType.stripeM2, CardReaderType.wisepad3]
 
     override func setUpWithError() throws {
         try super.setUpWithError()
@@ -33,7 +32,7 @@ class CardReaderManualsViewModelTests: XCTestCase {
         XCTAssertNotNil(viewModel)
     }
 
-    func test_viewModel_when_US_store_then_all_card_reader_manuals_are_available() {
+    func test_viewModel_when_US_store_then_available_card_reader_manuals() {
         // Given
         let setting = SiteSetting.fake()
             .copy(
@@ -47,13 +46,14 @@ class CardReaderManualsViewModelTests: XCTestCase {
         let viewModel = CardReaderManualsViewModel()
 
         // When
+        let availableReaderTypes = [CardReaderType.chipper, CardReaderType.stripeM2]
         let expectedManuals = availableReaderTypes.map { $0.manual }
 
         // Then
         XCTAssertEqual(viewModel.manuals, expectedManuals)
     }
 
-    func test_viewModel_when_CA_store_then_all_card_reader_manuals_are_available() {
+    func test_viewModel_when_CA_store_then_available_card_reader_manuals() {
         // Given
         let setting = SiteSetting.fake()
             .copy(
@@ -67,13 +67,14 @@ class CardReaderManualsViewModelTests: XCTestCase {
         let viewModel = CardReaderManualsViewModel()
 
         // When:
+        let availableReaderTypes = [CardReaderType.wisepad3]
         let expectedManuals = availableReaderTypes.map { $0.manual }
 
         // Then
         XCTAssertEqual(viewModel.manuals, expectedManuals)
     }
 
-    func test_viewModel_when_IPP_not_available_country_then_all_card_reader_manuals_are_available() {
+    func test_viewModel_when_IPP_not_available_country_then_available_card_reader_manuals_is_empty() {
         // Given
         let setting = SiteSetting.fake()
                     .copy(
@@ -86,6 +87,7 @@ class CardReaderManualsViewModelTests: XCTestCase {
         let viewModel = CardReaderManualsViewModel.init()
 
         // When
+        let availableReaderTypes: [CardReaderType] = []
         let expectedManuals = availableReaderTypes.map { $0.manual }
 
         // Then