Remove unused tagProductMilestone method

Author: ealeksandrov

WooCommerce/Classes/ViewRelated/Survey/SurveyViewController.swift

@@ -151,10 +151,6 @@ extension URL {
         appendingQueryItem(URLQueryItem(name: Tags.surveyRequestAppVersionTag, value: version))
     }
 
-    func tagProductMilestone(_ milestone: String) -> URL {
-        appendingQueryItem(URLQueryItem(name: Tags.surveyRequestProductMilestoneTag, value: milestone))
-    }
-
     func tagShippingLabelsMilestone(_ milestone: String) -> URL {
         appendingQueryItem(URLQueryItem(name: Tags.surveyRequestShippingLabelsMilestoneTag, value: milestone))
     }

WooCommerce/WooCommerceTests/ViewRelated/Survey/URL+SurveyViewControllerTests.swift

@@ -23,14 +23,6 @@ final class URL_SurveyViewControllerTests: XCTestCase {
         XCTAssertEqual(expectedURL, actualURL)
     }
 
-    func test_tagging_product_milestone_appends_the_correct_tag_data() throws {
-        let expectedURL = "https://testurl.com?product-milestone=test"
-
-        let actualURL = URL(string: "https://testurl.com")?.tagProductMilestone("test").absoluteString
-
-        XCTAssertEqual(expectedURL, actualURL)
-    }
-
     func test_tagging_shipping_labels_milestone_appends_the_correct_tag_data() throws {
         let expectedURL = "https://testurl.com?shipping_label_milestone=test"
 
@@ -39,26 +31,14 @@ final class URL_SurveyViewControllerTests: XCTestCase {
         XCTAssertEqual(expectedURL, actualURL)
     }
 
-    func test_tagging_platform_and_tagging_product_milestone_does_stack() throws {
-            let actualURL =
-                URL(string: "https://testurl.com")?
-                .tagPlatform("ios")
-                .tagProductMilestone("123")
-                .absoluteString
-
-            let expectedURL = "https://testurl.com?woo-mobile-platform=ios&product-milestone=123"
-
-            XCTAssertEqual(expectedURL, actualURL)
-    }
-
-    func test_tagging_platform_and_tagging_product_milestone_does_stack_in_order() throws {
+    func test_tagging_platform_and_tagging_shipping_labels_milestone_does_stack_in_order() throws {
         let actualURL =
             URL(string: "https://testurl.com")?
-            .tagProductMilestone("123")
+            .tagShippingLabelsMilestone("123")
             .tagPlatform("ios")
             .absoluteString
 
-        let expectedURL = "https://testurl.com?product-milestone=123&woo-mobile-platform=ios"
+        let expectedURL = "https://testurl.com?shipping_label_milestone=123&woo-mobile-platform=ios"
 
         XCTAssertEqual(expectedURL, actualURL)
     }