Skip to content

Commit 5767d3a

Browse files
committed
Remove magic numbers, update copy
1 parent 7b6d060 commit 5767d3a

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

WooCommerce/Classes/ViewRelated/Dashboard/Settings/In-Person Payments/Onboarding Errors/InPersonPaymentsSelectPluginView.swift

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ struct InPersonPaymentsSelectPlugin: View {
1313
message: Localization.message,
1414
image: InPersonPaymentsOnboardingError.ImageInfo(
1515
image: .paymentsPlugin,
16-
height: 108.0
16+
height: Constants.height
1717
),
1818
supportLink: false
1919
)
@@ -29,7 +29,7 @@ struct InPersonPaymentsSelectPlugin: View {
2929
}
3030
}
3131
.buttonStyle(PrimaryButtonStyle())
32-
.padding(.bottom, 24.0)
32+
.padding(.bottom, Constants.padding)
3333

3434
InPersonPaymentsLearnMore()
3535
}
@@ -52,16 +52,21 @@ private enum Localization {
5252
)
5353

5454
static let message = NSLocalizedString(
55-
"Choose between WooCommerce Payments and Stripe Extension",
55+
"You must disable either the WooCommerce Payments or the WooCommerce Stripe Gateway extension.",
5656
comment: "Message requesting merchants to select between available payments processors"
5757
)
5858

5959
static let primaryButton = NSLocalizedString(
6060
"Select extension in Store Admin",
61-
comment: "Button to set up the WooCommerce Payments plugin after installing it"
61+
comment: "Button to select the active payment processor plugin"
6262
)
6363
}
6464

65+
private enum Constants {
66+
static let height: CGFloat = 108.0
67+
static let padding: CGFloat = 24.0
68+
}
69+
6570
struct InPersonPaymentsSelectPlugin_Previews: PreviewProvider {
6671
static var previews: some View {
6772
InPersonPaymentsSelectPlugin(onRefresh: {})

0 commit comments

Comments
 (0)