feat: the background color is a constant now

pmusolino · pmusolino · commit 78f1f4b686de · 2022-02-16T10:49:16.000+01:00
diff --git a/WooCommerce/Classes/ViewRelated/Inbox/Inbox.swift b/WooCommerce/Classes/ViewRelated/Inbox/Inbox.swift
@@ -20,7 +20,7 @@ struct Inbox: View {
                     ForEach(viewModel.noteRowViewModels) { rowViewModel in
                         InboxNoteRow(viewModel: rowViewModel)
                     }
-                    .background(Color(.listForeground))
+                    .background(Constants.listForeground)
                 }
             case .empty:
                 // TODO: 5954 - update empty state
@@ -36,12 +36,12 @@ struct Inbox: View {
                                 .redacted(reason: .placeholder)
                                 .shimmering()
                         }
-                        .background(Color(.listForeground))
+                        .background(Constants.listForeground)
                     }
                 }
             }
         }
-        .background(Color(.listBackground).ignoresSafeArea())
+        .background(Constants.listBackground.ignoresSafeArea())
         .navigationTitle(Localization.title)
         .onAppear {
             viewModel.onLoadTrigger.send()
@@ -50,6 +50,12 @@ struct Inbox: View {
 }
 
 private extension Inbox {
+
+    enum Constants {
+        static let listForeground: Color = Color(.listForeground)
+        static let listBackground: Color = Color(.listBackground)
+    }
+
     enum Localization {
         static let title = NSLocalizedString("Inbox", comment: "Title for the screen that shows inbox notes.")
         static let emptyStateTitle = NSLocalizedString("Congrats, you’ve read everything!",

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ struct Inbox: View {`
`20`	`20`	`ForEach(viewModel.noteRowViewModels) { rowViewModel in`
`21`	`21`	`InboxNoteRow(viewModel: rowViewModel)`
`22`	`22`	`}`
`23`		`- .background(Color(.listForeground))`
	`23`	`+ .background(Constants.listForeground)`
`24`	`24`	`}`
`25`	`25`	`case .empty:`
`26`	`26`	`// TODO: 5954 - update empty state`
`@@ -36,12 +36,12 @@ struct Inbox: View {`
`36`	`36`	`.redacted(reason: .placeholder)`
`37`	`37`	`.shimmering()`
`38`	`38`	`}`
`39`		`- .background(Color(.listForeground))`
	`39`	`+ .background(Constants.listForeground)`
`40`	`40`	`}`
`41`	`41`	`}`
`42`	`42`	`}`
`43`	`43`	`}`
`44`		`- .background(Color(.listBackground).ignoresSafeArea())`
	`44`	`+ .background(Constants.listBackground.ignoresSafeArea())`
`45`	`45`	`.navigationTitle(Localization.title)`
`46`	`46`	`.onAppear {`
`47`	`47`	`viewModel.onLoadTrigger.send()`
`@@ -50,6 +50,12 @@ struct Inbox: View {`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`private extension Inbox {`
	`53`	`+`
	`54`	`+ enum Constants {`
	`55`	`+ static let listForeground: Color = Color(.listForeground)`
	`56`	`+ static let listBackground: Color = Color(.listBackground)`
	`57`	`+ }`
	`58`	`+`
`53`	`59`	`enum Localization {`
`54`	`60`	`static let title = NSLocalizedString("Inbox", comment: "Title for the screen that shows inbox notes.")`
`55`	`61`	`static let emptyStateTitle = NSLocalizedString("Congrats, you’ve read everything!",`