rename

iamgabrielma · iamgabrielma · commit 7a7492badeb6 · 2025-02-18T14:23:00.000+01:00
diff --git a/WooCommerce/Classes/POS/Analytics/POSCollectOrderPaymentAnalytics.swift b/WooCommerce/Classes/POS/Analytics/POSCollectOrderPaymentAnalytics.swift
@@ -20,7 +20,7 @@ final class POSCollectOrderPaymentAnalytics: CollectOrderPaymentAnalyticsTrackin
     func preflightResultReceived(_ result: CardReaderPreflightResult?) { }
     func trackProcessingCompletion(intent: Yosemite.PaymentIntent) { }
 
-    func trackSuccessfulPayment(capturedPaymentData: CardPresentCapturedPaymentData) {
+    func trackSuccessfulCardPayment(capturedPaymentData: CardPresentCapturedPaymentData) {
         // Property: milliseconds_since_customer_interaction_started
         let elapsedTimeSinceCustomerInteraction = calculateElapsedTimeInMilliseconds(since: customerInteractionStarted)
 
diff --git a/WooCommerce/Classes/ViewRelated/Orders/Collect Payments/CollectOrderPaymentAnalytics.swift b/WooCommerce/Classes/ViewRelated/Orders/Collect Payments/CollectOrderPaymentAnalytics.swift
@@ -9,7 +9,7 @@ protocol CollectOrderPaymentAnalyticsTracking {
 
     func trackProcessingCompletion(intent: PaymentIntent)
 
-    func trackSuccessfulPayment(capturedPaymentData: CardPresentCapturedPaymentData)
+    func trackSuccessfulCardPayment(capturedPaymentData: CardPresentCapturedPaymentData)
 
     func trackPaymentFailure(with error: Error)
 
@@ -90,7 +90,7 @@ final class CollectOrderPaymentAnalytics: CollectOrderPaymentAnalyticsTracking {
         }
     }
 
-    func trackSuccessfulPayment(capturedPaymentData: CardPresentCapturedPaymentData) {
+    func trackSuccessfulCardPayment(capturedPaymentData: CardPresentCapturedPaymentData) {
         analytics.track(event: WooAnalyticsEvent.InPersonPayments
             .collectPaymentSuccess(forGatewayID: paymentGatewayAccount?.gatewayID,
                                    countryCode: configuration.countryCode,
diff --git a/WooCommerce/Classes/ViewRelated/Orders/Collect Payments/CollectOrderPaymentUseCase.swift b/WooCommerce/Classes/ViewRelated/Orders/Collect Payments/CollectOrderPaymentUseCase.swift
@@ -377,7 +377,7 @@ private extension CollectOrderPaymentUseCase {
     /// Tracks the successful payments
     ///
     func handleSuccessfulPayment(capturedPaymentData: CardPresentCapturedPaymentData) {
-        analyticsTracker.trackSuccessfulPayment(capturedPaymentData: capturedPaymentData)
+        analyticsTracker.trackSuccessfulCardPayment(capturedPaymentData: capturedPaymentData)
     }
 
     func handlePaymentCancellation(from cancellationSource: WooAnalyticsEvent.InPersonPayments.CancellationSource) {
diff --git a/WooCommerce/WooCommerceTests/Mocks/MockCollectOrderPaymentAnalyticsTracker.swift b/WooCommerce/WooCommerceTests/Mocks/MockCollectOrderPaymentAnalyticsTracker.swift
@@ -15,7 +15,7 @@ final class MockCollectOrderPaymentAnalyticsTracker: CollectOrderPaymentAnalytic
 
     var didCallTrackSuccessfulPayment = false
     var spyTrackSuccessfulPaymentCapturedPaymentData: CardPresentCapturedPaymentData? = nil
-    func trackSuccessfulPayment(capturedPaymentData: CardPresentCapturedPaymentData) {
+    func trackSuccessfulCardPayment(capturedPaymentData: CardPresentCapturedPaymentData) {
         didCallTrackSuccessfulPayment = true
         spyTrackSuccessfulPaymentCapturedPaymentData = capturedPaymentData
     }
diff --git a/WooCommerce/WooCommerceTests/POS/Analytics/POSCollectOrderPaymentAnalyticsTests.swift b/WooCommerce/WooCommerceTests/POS/Analytics/POSCollectOrderPaymentAnalyticsTests.swift
@@ -25,7 +25,7 @@ struct POSCollectOrderPaymentAnalyticsTests {
         ]
 
         // When
-        sut.trackSuccessfulPayment(capturedPaymentData: capturedPaymentData)
+        sut.trackSuccessfulCardPayment(capturedPaymentData: capturedPaymentData)
 
         // Then
         #expect(analyticsProvider.receivedEvents.first(where: { $0 == expectedEvent }) != nil)

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ protocol CollectOrderPaymentAnalyticsTracking {`
`9`	`9`
`10`	`10`	`func trackProcessingCompletion(intent: PaymentIntent)`
`11`	`11`
`12`		`- func trackSuccessfulPayment(capturedPaymentData: CardPresentCapturedPaymentData)`
	`12`	`+ func trackSuccessfulCardPayment(capturedPaymentData: CardPresentCapturedPaymentData)`
`13`	`13`
`14`	`14`	`func trackPaymentFailure(with error: Error)`
`15`	`15`
`@@ -90,7 +90,7 @@ final class CollectOrderPaymentAnalytics: CollectOrderPaymentAnalyticsTracking {`
`90`	`90`	`}`
`91`	`91`	`}`
`92`	`92`
`93`		`- func trackSuccessfulPayment(capturedPaymentData: CardPresentCapturedPaymentData) {`
	`93`	`+ func trackSuccessfulCardPayment(capturedPaymentData: CardPresentCapturedPaymentData) {`
`94`	`94`	`analytics.track(event: WooAnalyticsEvent.InPersonPayments`
`95`	`95`	`.collectPaymentSuccess(forGatewayID: paymentGatewayAccount?.gatewayID,`
`96`	`96`	`countryCode: configuration.countryCode,`
Original file line number	Diff line number	Diff line change
`@@ -377,7 +377,7 @@ private extension CollectOrderPaymentUseCase {`
`377`	`377`	`/// Tracks the successful payments`
`378`	`378`	`///`
`379`	`379`	`func handleSuccessfulPayment(capturedPaymentData: CardPresentCapturedPaymentData) {`
`380`		`- analyticsTracker.trackSuccessfulPayment(capturedPaymentData: capturedPaymentData)`
	`380`	`+ analyticsTracker.trackSuccessfulCardPayment(capturedPaymentData: capturedPaymentData)`
`381`	`381`	`}`
`382`	`382`
`383`	`383`	`func handlePaymentCancellation(from cancellationSource: WooAnalyticsEvent.InPersonPayments.CancellationSource) {`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ final class MockCollectOrderPaymentAnalyticsTracker: CollectOrderPaymentAnalytic`
`15`	`15`
`16`	`16`	`var didCallTrackSuccessfulPayment = false`
`17`	`17`	`var spyTrackSuccessfulPaymentCapturedPaymentData: CardPresentCapturedPaymentData? = nil`
`18`		`- func trackSuccessfulPayment(capturedPaymentData: CardPresentCapturedPaymentData) {`
	`18`	`+ func trackSuccessfulCardPayment(capturedPaymentData: CardPresentCapturedPaymentData) {`
`19`	`19`	`didCallTrackSuccessfulPayment = true`
`20`	`20`	`spyTrackSuccessfulPaymentCapturedPaymentData = capturedPaymentData`
`21`	`21`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ struct POSCollectOrderPaymentAnalyticsTests {`
`25`	`25`	`]`
`26`	`26`
`27`	`27`	`// When`
`28`		`- sut.trackSuccessfulPayment(capturedPaymentData: capturedPaymentData)`
	`28`	`+ sut.trackSuccessfulCardPayment(capturedPaymentData: capturedPaymentData)`
`29`	`29`
`30`	`30`	`// Then`
`31`	`31`	`#expect(analyticsProvider.receivedEvents.first(where: { $0 == expectedEvent }) != nil)`