Skip to content

Commit 7b9d692

Browse files
authored
Background image upload: Fix missing error notice in iPhones (#15117)
2 parents ff61bb5 + 74c6bd5 commit 7b9d692

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

RELEASE-NOTES.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
- [*] Now "Suggested by AI" label is visible in dark mode in Blaze campaign creation flow. [https://github.com/woocommerce/woocommerce-ios/pull/15088]
77
- [*] Improved image loading in Blaze Campaign Creation: displays a redacted and shimmering effects when loading product image and falls back to a placeholder if no image is available. [https://github.com/woocommerce/woocommerce-ios/pull/15098]
88
- [*] Product List: Display syncing animation on items with image upload in progress [https://github.com/woocommerce/woocommerce-ios/pull/15052]
9+
- [*] Background image upload: Fix missing error notice in iPhones [https://github.com/woocommerce/woocommerce-ios/pull/15117]
910

1011
21.7
1112
-----

WooCommerce/Classes/ViewRelated/Products/ProductsSplitViewCoordinator.swift

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,12 @@ private extension ProductsSplitViewCoordinator {
230230
extension ProductsSplitViewCoordinator: UINavigationControllerDelegate {
231231
func navigationController(_ navigationController: UINavigationController, didShow viewController: UIViewController, animated: Bool) {
232232
if didNavigateFromTheLastSecondaryViewControllerToProductListInCollapsedMode(navigationController, didShow: viewController) {
233+
if let contentType = contentTypes.last, case let .productForm(product) = contentType, let product {
234+
ServiceLocator.productImageUploader.startEmittingErrors(
235+
key: .init(siteID: product.siteID,
236+
productOrVariationID: .product(id: product.productID),
237+
isLocalID: false))
238+
}
233239
contentTypes = []
234240
secondaryNavigationController.viewControllers = []
235241
return

0 commit comments

Comments
 (0)