Skip to content

Commit 7bba37a

Browse files
committed
Update system status mapper tests to test active attribute on plugins
1 parent f23edea commit 7bba37a

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

Networking/NetworkingTests/Mapper/SystemStatusMapperTests.swift

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,8 @@ class SystemStatusMapperTests: XCTestCase {
2121
let expectedVersionLatest = "5.8.0"
2222
let expectedAuthorName = "Automattic"
2323
let expectedAuthorUrl = "https://woocommerce.com"
24-
/// TODO - The mapper is overriding networkActivated to be true for active plugins in general
25-
/// When we fix #5269 this test will need to be updated to properly test the
26-
/// new `activated` attribute that will be added to SystemPlugin instead
27-
let expectedNetworkActivated = true
24+
let expectedNetworkActivated = false
25+
let expectedActive = true
2826

2927
// When
3028
let systemPlugins = try mapLoadSystemStatusResponse()
@@ -43,6 +41,7 @@ class SystemStatusMapperTests: XCTestCase {
4341
XCTAssertEqual(systemPlugin.authorName, expectedAuthorName)
4442
XCTAssertEqual(systemPlugin.authorUrl, expectedAuthorUrl)
4543
XCTAssertEqual(systemPlugin.networkActivated, expectedNetworkActivated)
44+
XCTAssertEqual(systemPlugin.active, expectedActive)
4645
}
4746

4847
/// Verifies the SystemPlugin fields are parsed correctly for an inactive plugin
@@ -57,10 +56,8 @@ class SystemStatusMapperTests: XCTestCase {
5756
let expectedVersionLatest = "1.7.2"
5857
let expectedAuthorName = "Matt Mullenweg"
5958
let expectedAuthorUrl = "http://ma.tt/"
60-
/// TODO - The mapper is overriding networkActivated to be true for active plugins in general
61-
/// When we fix #5269 this test will need to be updated to properly test the
62-
/// new `activated` attribute that will be added to SystemPlugin instead
6359
let expectedNetworkActivated = false
60+
let expectedActive = false
6461

6562
// When
6663
let systemPlugins = try mapLoadSystemStatusResponse()
@@ -79,6 +76,7 @@ class SystemStatusMapperTests: XCTestCase {
7976
XCTAssertEqual(systemPlugin.authorName, expectedAuthorName)
8077
XCTAssertEqual(systemPlugin.authorUrl, expectedAuthorUrl)
8178
XCTAssertEqual(systemPlugin.networkActivated, expectedNetworkActivated)
79+
XCTAssertEqual(systemPlugin.active, expectedActive)
8280
}
8381
}
8482

0 commit comments

Comments
 (0)