Skip to content

Commit a24425f

Browse files
committed
Merge branch 'feat/15110-ds-radius' into feat/15112-ds-shadow
2 parents 7b9d692 + 050b512 commit a24425f

13 files changed

+59
-33
lines changed

WooCommerce/Classes/POS/Presentation/CardReaderConnection/CardReaderConnectionStatusView.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ private extension CardReaderConnectionStatusView {
113113
static let progressIndicatorLineWidth: CGFloat = 2
114114
static let font = POSFontStyle.posBodyMediumRegular()
115115
static let horizontalPadding: CGFloat = 24
116-
static let overlayRadius: CGFloat = 4
116+
static let overlayRadius: CGFloat = POSCornerRadiusStyle.small.value
117117
static let overlayLineWidth: CGFloat = 2
118118
static let overlayColor: Color = Color.init(uiColor: .wooCommercePurple(.shade60))
119119
static let overlayInnerHorizontalPadding: CGFloat = 16 + Self.overlayLineWidth

WooCommerce/Classes/POS/Presentation/ItemListView.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ struct GhostItemCardView: View {
205205

206206
private extension GhostItemCardView {
207207
enum Constants {
208-
static let cornerRadius: CGFloat = 8
208+
static let cornerRadius: CGFloat = POSCornerRadiusStyle.medium.value
209209
static let cardForegroundColor: Color = Color.gray.opacity(0.5)
210210
static let textForegroundColor: Color = Color.gray.opacity(0.8)
211211
static let productCardSize: CGFloat = 112
@@ -221,7 +221,7 @@ private extension ItemListView {
221221
enum Constants {
222222
static let bannerTitleFont: POSFontStyle = .posBodyLargeBold
223223
static let bannerSubtitleFont: POSFontStyle = .posBodySmallRegular()
224-
static let bannerCornerRadius: CGFloat = 8
224+
static let bannerCornerRadius: CGFloat = POSCornerRadiusStyle.medium.value
225225
static let bannerVerticalPadding: CGFloat = 26
226226
static let bannerTextSpacing: CGFloat = 4
227227
static let bannerTitleSpacing: CGFloat = 8

WooCommerce/Classes/POS/Presentation/POSFloatingControlView.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ extension POSFloatingControlView {
101101
private extension POSFloatingControlView {
102102
enum Constants {
103103
static let size: CGFloat = 56
104-
static let cornerRadius: CGFloat = 8
104+
static let cornerRadius: CGFloat = POSCornerRadiusStyle.medium.value
105105
}
106106

107107
enum Localization {

WooCommerce/Classes/POS/Presentation/POSReceiptEligibilityBanner.swift

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ struct POSReceiptEligibilityBanner: View {
2929
private extension POSReceiptEligibilityBanner {
3030
enum Constants {
3131
static let elementSpacing: CGFloat = 8
32-
static let cornerRadius: CGFloat = 20
32+
static let cornerRadius: CGFloat = POSCornerRadiusStyle.large.value
3333
static let imagesize: CGFloat = 40
3434
static let imagePadding: CGFloat = 4
3535
static let bannerPadding: CGFloat = 16
@@ -42,3 +42,8 @@ private extension POSReceiptEligibilityBanner {
4242
comment: "Text for the banner requiring specific WooCommerce version.")
4343
}
4444
}
45+
46+
#Preview {
47+
POSReceiptEligibilityBanner(isVisible: .constant(true))
48+
.padding()
49+
}

WooCommerce/Classes/POS/Presentation/Reusable Views/Buttons/POSButtonStyle.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ private struct POSButton: View {
137137

138138
private extension POSButton {
139139
enum Constants {
140-
static let cornerRadius: CGFloat = 8.0
140+
static let cornerRadius: CGFloat = POSCornerRadiusStyle.medium.value
141141
static let borderStrokeWidth: CGFloat = 2.0
142142
}
143143
}

WooCommerce/Classes/POS/Presentation/Reusable Views/POSConnectivityView.swift

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,19 +28,19 @@ struct POSConnectivityView: View {
2828
@ViewBuilder private var noConnectionBanner: some View {
2929
HStack(spacing: Constants.spacing) {
3030
Image(systemName: "wifi.exclamationmark")
31-
.foregroundColor(Color(.text.inverted))
31+
.foregroundColor(Color.posOnSecondaryContainer)
3232
.font(.posBodySmallBold)
3333

3434
Text(Localization.title)
35-
.foregroundColor(Color(.text.inverted))
35+
.foregroundColor(Color.posOnSecondaryContainer)
3636
.font(.posBodySmallBold)
3737
}
3838
.padding(.vertical, Constants.verticalPadding)
3939
.padding(.horizontal, Constants.horizontalPadding)
4040
.frame(minHeight: Constants.height)
41-
.background(Color(.systemGray6.inverted))
41+
.background(Color.posSecondaryContainer)
4242
.cornerRadius(Constants.cornerRadius)
43-
.shadow(color: Color.black.opacity(0.2), radius: 8, x: 0, y: 2)
43+
.shadow(color: Color.posShadow.opacity(0.2), radius: 8, x: 0, y: 2)
4444
.frame(maxWidth: .infinity, maxHeight: .infinity, alignment: .top)
4545
}
4646

@@ -51,7 +51,7 @@ struct POSConnectivityView: View {
5151

5252
private extension POSConnectivityView {
5353
enum Constants {
54-
static let cornerRadius: CGFloat = 16
54+
static let cornerRadius: CGFloat = POSCornerRadiusStyle.large.value
5555
static let height: CGFloat = 64
5656
static let spacing: CGFloat = 16
5757
static let horizontalPadding: CGFloat = 24
@@ -67,3 +67,8 @@ private extension POSConnectivityView {
6767
)
6868
}
6969
}
70+
71+
#Preview {
72+
// To enable preview, set `isVisible` to `true` and comment out `onAppear` block.
73+
POSConnectivityView()
74+
}

WooCommerce/Classes/POS/Presentation/Reusable Views/POSItemCardBorderStylesModifier.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ struct POSItemCardBorderStylesModifier: ViewModifier {
1515

1616
private extension POSItemCardBorderStylesModifier {
1717
enum Constants {
18-
static let cardCornerRadius: CGFloat = 8.0
18+
static let cardCornerRadius: CGFloat = POSCornerRadiusStyle.medium.value
1919
// The use of stroke means the shape is rendered as an outline (border) rather than a filled shape,
2020
// since we still have to give it a value, we use 0 so it renders no border but it's shaped as one.
2121
static let nilOutline: CGFloat = 0

WooCommerce/Classes/POS/Presentation/Reusable Views/POSModalViewModifier.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ struct POSRootModalViewModifier: ViewModifier {
2626
ZStack {
2727
modalManager.getContent()
2828
.background(Color.posSurfaceBright)
29-
.cornerRadius(24)
29+
.cornerRadius(POSCornerRadiusStyle.extraLarge.value)
3030
.shadow(color: Color.posShadow.opacity(0.02), radius: 43, x: 0, y: 50) // 0px 50px 43px 0px #00000005
3131
.shadow(color: Color.posShadow.opacity(0.04), radius: 36, x: 0, y: 30) // 0px 30px 36px 0px #0000000A
3232
.shadow(color: Color.posShadow.opacity(0.07), radius: 27, x: 0, y: 15) // 0px 15px 27px 0px #00000012

WooCommerce/Classes/POS/Presentation/SimpleProductsOnlyInformation.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ private extension SimpleProductsOnlyInformation {
7373
static let modalContentPadding: CGFloat = 40
7474
static let hintVerticalPadding: CGFloat = 24
7575
static let hintHorizontalPadding: CGFloat = 40
76-
static let hintBackgroundCornerRadius: CGFloat = 8
76+
static let hintBackgroundCornerRadius: CGFloat = POSCornerRadiusStyle.medium.value
7777
static let contentBlockSpacing: CGFloat = 40
7878
static let textSpacing: CGFloat = 16
7979
static let textToModalBottomPadding: CGFloat = 8

WooCommerce/Classes/POS/Presentation/TotalsView.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,7 @@ private extension TotalsView {
356356
static let totalAmountFont: POSFontStyle = .posHeading
357357
static let separatorColor: Color = Color.posOutlineVariant
358358

359-
static let shimmeringCornerRadius: CGFloat = 4
359+
static let shimmeringCornerRadius: CGFloat = POSCornerRadiusStyle.small.value
360360
static let shimmeringWidth: CGFloat = 334
361361
static let subtotalsShimmeringHeight: CGFloat = 36
362362
static let totalShimmeringHeight: CGFloat = 40

0 commit comments

Comments
 (0)