-
Notifications
You must be signed in to change notification settings - Fork 119
[Brand Updates] Update prologue screen #14773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Brand Updates] Update prologue screen #14773
Conversation
Only in iOS 16.4+ for now
Generated by 🚫 Danger |
|
|
| override var supportedInterfaceOrientations: UIInterfaceOrientationMask { | ||
| return .portrait |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this part, we don't enforce any orientation now, the Authentication library still enforces portrait orientation for phones, but at least now iPads can show the app in landscape.
itsmeichigo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested both light and dark modes on iPhone SE, iPhone 16 Plus and iPad mini simulators and confirmed that the prologue screen now looks as expected.
6320cbb to
3f424c1
Compare
b903b2a
into
feature/woo-2.0-brand-updates
Closes: woocommerce/woomobile-private#385
Description
This PR updates the prologue screen design to match the new brand update (Ntkk0ER4hHt5y9KjEGIiGk-fi-2603_9953), the changes are based on the Authenticator library PR, and in addition to this, the prologue top section is updated to use SwiftUI, and is decoupled now from the carousel content.
Steps to reproduce
Testing information
Tested using an iPhone 16 and iPad 10th gen simulators, iOS 18.1.
Screenshots
RELEASE-NOTES.txtif necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: