Skip to content

Conversation

@hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented Dec 30, 2024

Closes: woocommerce/woomobile-private#385

Description

This PR updates the prologue screen design to match the new brand update (Ntkk0ER4hHt5y9KjEGIiGk-fi-2603_9953), the changes are based on the Authenticator library PR, and in addition to this, the prologue top section is updated to use SwiftUI, and is decoupled now from the carousel content.

Steps to reproduce

  1. Logout if needed.
  2. Open the app and check the prologue screen.

Testing information

  • Confirm the prologue behaves correctly in different screen sizes.
  • Confirm the prologue look in dark and light themes.

Tested using an iPhone 16 and iPad 10th gen simulators, iOS 18.1.

Screenshots

Light Dark
Simulator Screenshot - iPhone 16 - 2024-12-31 at 13 33 49 Simulator Screenshot - iPhone 16 - 2024-12-31 at 13 34 01
Simulator Screenshot - iPad (10th generation) - 2024-12-31 at 13 35 51 Simulator Screenshot - iPad (10th generation) - 2024-12-31 at 13 35 57
Simulator Screenshot - iPad (10th generation) - 2024-12-31 at 13 36 08 Simulator Screenshot - iPad (10th generation) - 2024-12-31 at 13 36 03

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@hichamboushaba hichamboushaba added type: enhancement A request for an enhancement. feature: login Related to any part of the log in or sign in flow, or authentication. category: design Layout and style elements in the UI or user interface, including color and animations. labels Dec 30, 2024
@hichamboushaba hichamboushaba changed the base branch from trunk to feature/woo-2.0-brand-updates December 30, 2024 18:51
@dangermattic
Copy link
Collaborator

dangermattic commented Dec 30, 2024

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@hichamboushaba hichamboushaba changed the title [Brand Updates] New prologue screen [Brand Updates] Update prologue screen Dec 30, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 30, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14773-3f424c1
Version21.2
Bundle IDcom.automattic.alpha.woocommerce
Commit3f424c1
App Center BuildWooCommerce - Prototype Builds #12326
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Comment on lines -32 to -33
override var supportedInterfaceOrientations: UIInterfaceOrientationMask {
return .portrait
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this part, we don't enforce any orientation now, the Authentication library still enforces portrait orientation for phones, but at least now iPads can show the app in landscape.

@hichamboushaba hichamboushaba marked this pull request as ready for review December 31, 2024 08:57
@itsmeichigo itsmeichigo self-assigned this Jan 2, 2025
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both light and dark modes on iPhone SE, iPhone 16 Plus and iPad mini simulators and confirmed that the prologue screen now looks as expected.

@hichamboushaba hichamboushaba removed the status: do not merge Dependent on another PR, ready for review but not ready for merge. label Jan 2, 2025
@hichamboushaba hichamboushaba merged commit b903b2a into feature/woo-2.0-brand-updates Jan 2, 2025
12 checks passed
@hichamboushaba hichamboushaba deleted the task/woo-2.0-prologue branch January 2, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: design Layout and style elements in the UI or user interface, including color and animations. feature: login Related to any part of the log in or sign in flow, or authentication. type: enhancement A request for an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants