Rename PULL_REQUEST_NUMBER to pull_request_number
#16435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Collaborator
Generated by 🚫 Danger |
Co-authored-by: mokagio <[email protected]>
dangermattic
reviewed
Dec 5, 2025
Copilot
AI
changed the title
[WIP] Fix naming convention for pull_request_number
Rename Dec 5, 2025
PULL_REQUEST_NUMBER to pull_request_number
Copilot finished work on behalf of
mokagio
December 5, 2025 00:34
Co-authored-by: mokagio <[email protected]>
AliSoftware
approved these changes
Dec 5, 2025
Copilot finished work on behalf of
mokagio
December 5, 2025 00:55
mokagio
approved these changes
Dec 5, 2025
mokagio
merged commit 66961b3
into
ainfra-1614-build-wc-ios-prototypes-from-trunk
8 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses review feedback from @AliSoftware: The uppercase
PULL_REQUEST_NUMBERincorrectly uses Ruby constant naming convention for a value that changes per PR run. True constants likeFIREBASE_APP_IDnever change across runs—this value does.Changed to lowercase
pull_request_numberto reflect it's a runtime variable, not a constant. Moved the variable definition to the top of the Fastfile so lanes declared after it can read and access it.Test Steps
Syntax validation only—no behavioral changes:
ruby -c fastlane/Fastfile # Syntax OKScreenshots
N/A - No UI changes.
RELEASE-NOTES.txtif necessary.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.