Skip to content

Switch screenshots ASC orientation for iPad so all screenshots are landscape#16578

Open
iamgabrielma wants to merge 6 commits intoainfra-1812-fix-asc-screenshot-upload-generated-screenshots-not-commitedfrom
task/make-asc-ipad-screenshots-horizontal
Open

Switch screenshots ASC orientation for iPad so all screenshots are landscape#16578
iamgabrielma wants to merge 6 commits intoainfra-1812-fix-asc-screenshot-upload-generated-screenshots-not-commitedfrom
task/make-asc-ipad-screenshots-horizontal

Conversation

@iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Jan 29, 2026

Updates WooCommerceScreenshots and screenshots.json to make all iPad screenshots for ASC in landscape mode.

Description

This PR updates the UI tests for ASC screenshots so these are always performed in landscape when the device is an iPad. This is done to avoid miss-matches in ASC between portrait and landscape devices, which causes screenshots to not look the best.

Test Steps

No need for much testing, this was done extensively on thread_ts=1769135008.118939&cid=CC7L49W13-slack-CC7L49W13/p1770097840479439 . We only change the orientation, so running UI tests locally in Xcode and observing the screenshots are captured in landscape would be sufficient.

If you want to test further, for the whole flow it can be done by:

bundle exec fastlane screenshots (creates the raw screenshots)
bundle exec fastlane download_localized_strings_and_metadata_from_glotpress (downloads latest localizations)
bundle exec fastlane create_promo_screenshots (mounts screenshots)

Depending on your machine setup, you may also need the following dependencies, which will be prompted if needed by erroring in terminal:

brew install imagemagick
brew install automattic/build-tools/drawText
bundle install --with screenshots
bundle exec fastlane create_promo_screenshots

I also had to update .xcode-version and Fastfile's SIMULATOR_VERSION to match my environment (Xcode 26.2.0) of would error out when running bundle exec fastlane screenshots

Screenshot 2026-02-09 at 10 24 02

@iamgabrielma iamgabrielma changed the title switch ipad orientation so all screenshots are landscape Switch screenshots ASC orientation for iPad so all screenshots are landscape Jan 29, 2026
@iamgabrielma iamgabrielma added type: task An internally driven task. feature: POS labels Jan 29, 2026
@iamgabrielma iamgabrielma added this to the 24.0 ❄️ milestone Jan 29, 2026
@iamgabrielma iamgabrielma added the generate screenshots Triggers a GitHub Action to generate screenshots for this PR. label Jan 29, 2026
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 29, 2026

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16578-8e9ca51
Version24.0
Bundle IDcom.automattic.alpha.woocommerce
Commit8e9ca51
Installation URL2dsq864okge58
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

iangmaia and others added 4 commits January 29, 2026 11:31
…hots-not-commited' into task/make-asc-ipad-screenshots-horizontal
…hots-not-commited' into task/make-asc-ipad-screenshots-horizontal
…hots-not-commited' into task/make-asc-ipad-screenshots-horizontal
@iamgabrielma iamgabrielma removed the generate screenshots Triggers a GitHub Action to generate screenshots for this PR. label Feb 3, 2026
@joshheald joshheald removed this from the 24.0 ❄️ milestone Feb 6, 2026
@joshheald joshheald marked this pull request as draft February 6, 2026 10:05
@joshheald
Copy link
Contributor

Removed 24 and switched to draft. @iamgabrielma up to you whether we close this

@iamgabrielma iamgabrielma marked this pull request as ready for review February 9, 2026 03:27
@iamgabrielma iamgabrielma added this to the 24.2 milestone Feb 9, 2026
@iamgabrielma iamgabrielma requested a review from adborbas February 9, 2026 03:28
@iamgabrielma iamgabrielma changed the base branch from ainfra-1812-fix-asc-screenshot-upload-generated-screenshots-not-commited to trunk February 9, 2026 15:50
@iamgabrielma iamgabrielma changed the base branch from trunk to ainfra-1812-fix-asc-screenshot-upload-generated-screenshots-not-commited February 9, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: POS type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants