Switch screenshots ASC orientation for iPad so all screenshots are landscape#16578
Open
iamgabrielma wants to merge 6 commits intoainfra-1812-fix-asc-screenshot-upload-generated-screenshots-not-commitedfrom
Conversation
Collaborator
|
|
…hots-not-commited' into task/make-asc-ipad-screenshots-horizontal
…hots-not-commited' into task/make-asc-ipad-screenshots-horizontal
…hots-not-commited' into task/make-asc-ipad-screenshots-horizontal
1 task
Contributor
|
Removed 24 and switched to draft. @iamgabrielma up to you whether we close this |
adborbas
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Updates
WooCommerceScreenshotsandscreenshots.jsonto make all iPad screenshots for ASC in landscape mode.Description
This PR updates the UI tests for ASC screenshots so these are always performed in landscape when the device is an iPad. This is done to avoid miss-matches in ASC between portrait and landscape devices, which causes screenshots to not look the best.
Test Steps
No need for much testing, this was done extensively on thread_ts=1769135008.118939&cid=CC7L49W13-slack-CC7L49W13/p1770097840479439 . We only change the orientation, so running UI tests locally in Xcode and observing the screenshots are captured in landscape would be sufficient.
If you want to test further, for the whole flow it can be done by:
Depending on your machine setup, you may also need the following dependencies, which will be prompted if needed by erroring in terminal:
I also had to update
.xcode-versionand Fastfile'sSIMULATOR_VERSIONto match my environment (Xcode 26.2.0) of would error out when runningbundle exec fastlane screenshots