Convert Resources group to synchronized folder#16589
Merged
Conversation
Collaborator
|
|
mokagio
force-pushed
the
ainfra-1874-convert-woo-ios-resources-to-synchronized-folders
branch
from
dbad789 to
d8fa4d5
Compare
mokagio
added
the
category: tooling
mokagio
force-pushed
the
ainfra-1874-convert-woo-ios-resources-to-synchronized-folders
branch
from
d8fa4d5 to
1979c2e
Compare
iangmaia
approved these changes
Feb 4, 2026
Contributor
iangmaia
left a comment
iangmaia
left a comment
There was a problem hiding this comment.
👍 I've opened the project in Xcode and it looks good to me.
Contributor
I don't think that's a big deal, though. If we wanted to, I guess we could place it somewhere also under |
This will enable adopting synchronized folders for Resources.
The downside is that `AppStoreString.pot` and `release_notes.txt` are now accessible from Xcode. That's not necessarily bad, but it is a bit confusing given those files are unrelated to the app source code itself. `release_notes.txt` will be easy to remove. We've long been meaning to use the Fastlane counterpart as the source of truth for release notes. The `pot` file might be less straightforward. For once, we'll need to update the GlotPress automation as well. But the real question is: Where should we place it?
mokagio
force-pushed
the
ainfra-1874-convert-woo-ios-resources-to-synchronized-folders
branch
from
1979c2e to
8b35648
Compare
Collaborator
Generated by 🚫 Danger |
mokagio
deleted the
ainfra-1874-convert-woo-ios-resources-to-synchronized-folders
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See AINFRA-1874: Convert Woo iOS Resources to synchronized folders. See also #16565
The downside is that
AppStoreString.potandrelease_notes.txtare now accessible from Xcode. That's not necessarily bad, but it is a bit confusing given those files are unrelated to the app source code itself.release_notes.txtwill be easy to remove. We've long been meaning to use the Fastlane counterpart as the source of truth for release notes.The
potfile might be less straightforward. For once, we'll need to update the GlotPress automation as well. But the real question is: Where should we place it?Test Steps
Take the prototype build for a spin.
I did so and all the icons and colors looked right.
Screenshots
RELEASE-NOTES.txtif necessary. — N.A.