[POS FTS] 3: Add inline FTS indexing to catalog persistence #16596
+227
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds indexProduct, indexVariation, and removeFromIndex to POSSearchIndexBuilder for per-item FTS updates within existing transactions. Refactors indexAllProducts/indexAllVariations to use these methods. Wires up inline FTS indexing in POSCatalogPersistenceService: - replaceAllCatalogData clears and rebuilds the index inline - persistIncrementalCatalogData removes old entries before re-indexing - deleteProducts removes FTS entries before deleting records Co-Authored-By: Claude Opus 4.5 <[email protected]>
1 task
Collaborator
Generated by 🚫 Danger |
Collaborator
|
|
joshheald
commented
Jan 30, 2026
Comment on lines
+43
to
+47
| /// - Parameters: | ||
| /// - siteID: The site ID to search within | ||
| /// - term: The search term | ||
| /// - db: The database to search in | ||
| /// - Returns: Total count of matching results |
Contributor
Author
There was a problem hiding this comment.
Move these to the previous PR?
Comment on lines
+62
to
+65
| /// - Parameters: | ||
| /// - siteID: The site ID to check | ||
| /// - db: The database to check in | ||
| /// - Returns: True if rebuild is needed |
Contributor
Author
There was a problem hiding this comment.
Move these to the previous PR?
Comment on lines
+84
to
+89
| // MARK: - Inline Indexing (same transaction) | ||
|
|
||
| /// Clears the FTS index for a site. | ||
| /// - Parameters: | ||
| /// - siteID: The site ID to clear | ||
| /// - db: The database (must be called within a write transaction) |
Contributor
Author
There was a problem hiding this comment.
Move these to the previous PR?
| // MARK: - Private | ||
|
|
||
| private static func buildFTSQuery(from term: String) -> String { | ||
| // Split on non-alphanumeric characters to match FTS5's unicode61 tokenizer behavior |
Contributor
Author
There was a problem hiding this comment.
Move these to the previous PR?
| try image.insert(db, onConflict: .replace) | ||
| } | ||
|
|
||
| // Then insert join table entries |
| } | ||
|
|
||
| for variation in catalog.variationsToPersist { | ||
| // Delete attributes for updated variations, the remaining set will be recreated later in the save |
Contributor
Author
There was a problem hiding this comment.
Retain full comment below
| try image.save(db) | ||
| } | ||
|
|
||
| // Upsert new join table entries |
| try site?.updateChanges(db) { $0.lastCatalogIncrementalSyncDate = catalog.syncDate } | ||
| } | ||
|
|
||
| // Delete products hidden from POS when detected during incremental sync |
Contributor
Author
There was a problem hiding this comment.
Retain and add FTS details
|
|
||
| DDLogInfo("✅ Incremental catalog persistence complete") | ||
|
|
||
| try await grdbManager.databaseConnection.read { db in |
| } | ||
|
|
||
| func deleteProducts(_ productIDs: [Int64], variationIDs: [Int64], siteID: Int64) async throws { | ||
| public func deleteProducts(_ productIDs: [Int64], variationIDs: [Int64], siteID: Int64) async throws { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: WOOMOB-2109
Merge after #16595
Description
Adds per-item indexing methods to
POSSearchIndexBuilder:indexProduct: indexes a single product (filters by eligibility internally)indexVariation: indexes a single variation with parent product name and attributesremoveFromIndex: removes a specific item from the FTS indexRefactors
indexAllProducts/indexAllVariationsto delegate to these methods.Wires up inline FTS indexing in
POSCatalogPersistenceService:replaceAllCatalogDataclears and rebuilds the index inline during full syncpersistIncrementalCatalogDataremoves old entries before re-indexing updated itemsdeleteProductsremoves FTS entries before deleting recordsTest Steps
POSSearchIndexBuilderTestsandPOSCatalogPersistenceServiceTests— all tests should passRELEASE-NOTES.txtif necessary.