Skip to content

Comments

Add push notification setup tracking events#16711

Open
adborbas wants to merge 14 commits intotrunkfrom
adborbas/push-notif-tracking
Open

Add push notification setup tracking events#16711
adborbas wants to merge 14 commits intotrunkfrom
adborbas/push-notif-tracking

Conversation

@adborbas
Copy link
Contributor

@adborbas adborbas commented Feb 23, 2026 •
edited
Loading

Closes WOOMOB-2279

Description

Adds analytics tracking for the WPCom push notification setup flow defined in pe5sF9-4Xn-p2

Test Steps

Run the app on a simulator and monitor the Xcode debug console for tracked events.

Event Properties When
push_notifications_card_view (none) When the dashboard card is displayed
settings_push_notifications_button_tap (none) "Enable Push Notifications" tapped in settings
push_notifications_setup_introduction_view (none) Benefits view opened
push_notifications_setup_introduction_button_tap button_label:
continue | not_now | update_plugin		 CTA tapped on benefits view
push_notifications_setup_introduction_link_tap (none) "What is WordPress.com?" link tapped on benefits view
push_notifications_setup_introduction_error error_type:
no_permission | generic		 Error happened on benefits view
push_notifications_setup_flow_success step:
connect_wpcom | plugin_compatibility | enable_push_notifications		 Setup step completed
push_notifications_setup_flow_button_tap button_label:
go_to_my_store | try_again | update_plugin		 CTA tapped on setup steps
push_notifications_setup_flow_close (none) Dismissing the setup steps
push_notifications_setup_flow_error step:
connect_wpcom | plugin_compatibility | enable_push_notifications		 Error on setup step

Screenshots

N/A

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dangermattic
Copy link
Collaborator

dangermattic commented Feb 23, 2026 •
edited
Loading

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
1 Message
📖

This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed:

  • The tracks events must be validated in the Tracks system.
  • Verify the internal Tracks spreadsheet has also been updated.
  • Please consider registering any new events.
  • The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 23, 2026 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16711-1bf85fe
Version24.1
Bundle IDcom.automattic.alpha.woocommerce
Commit1bf85fe
Installation URL1o8qnhunt329g
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@adborbas adborbas force-pushed the adborbas/push-notif-tracking branch from a76dd97 to dc0c7fa Compare February 24, 2026 08:01
@adborbas adborbas added this to the 24.2 milestone Feb 24, 2026
@adborbas adborbas added type: task An internally driven task. category: tracks Related to analytics, including Tracks Events. and removed type: task An internally driven task. labels Feb 24, 2026
@adborbas adborbas marked this pull request as ready for review February 24, 2026 10:08
adborbas and others added 9 commits February 24, 2026 13:18
@adborbas @claude
Add push notification setup tracking events
f3edd2d 
Instrument 8 analytics events for the push notification setup flow:
card view, settings tap, introduction view/buttons, flow success/error,
flow button taps, and flow close.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@adborbas @claude
Migrate PushNotificationsSetup tests to Swift Testing conventions
4736f9b 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@adborbas @claude
Add introduction error tracking using VariantCheckError types
ef41d2d 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@adborbas @claude
Consolidate analytics tests and remove tuple helpers
14fe914 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@adborbas @claude
Add missing Foundation import for Swift Testing test file
8da0515 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@adborbas @claude
Fix ViewModel premature deallocation in step update tests
02fd577 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@adborbas @claude
Simplify analytics by removing factory methods for error and step events
d2a514c 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@adborbas @claude
Move analytics mapping extensions to analytics file
ffdc844 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@adborbas @claude
Rename analytics enums and parameter labels for clarity
d8ebf78 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@adborbas adborbas force-pushed the adborbas/push-notif-tracking branch from 191025c to d8ebf78 Compare February 24, 2026 12:18
adborbas and others added 5 commits February 24, 2026 13:21
@adborbas @claude
Rename analytics enum and files to WPComPushNotificationsSetup
1172da8 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@adborbas @claude
Add missing Foundation import for LocalizedError conformance
ab307e1 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@adborbas @claude
Address review feedback: cleanup and improvements
3e594ab 
- Fix extra spaces in analytics factory method calls
- Remove unused SetupButton.done enum case
- Rename noMissingRequirements to setupNotRequired
- Remove setup_not_required analytics tracking (not a real error)
- Add pushNotificationsSetupIntroductionLinkTap event for whatIsWPCom
- Replace duplicated assertEqual helpers with MockAnalyticsProvider.assertReceived

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@adborbas @claude
Revert setupNotRequired rename back to noMissingRequirements
703ac2f 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@adborbas @claude
Remove unused doneTapped and isShowingDoneButton
1bf85fe 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
adborbas
adborbas commented Feb 24, 2026
View reviewed changes
...e/Classes/Authentication/WPComLogin/WPComConnectionSetup/WPComConnectionSetupViewModel.swift
Localization.tryAgain
}

var isShowingDoneButton: Bool {
Copy link
Contributor Author

@adborbas adborbas Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done button was not used on the UI

@adborbas adborbas requested review from RafaelKayumov and itsmeichigo and removed request for itsmeichigo February 24, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafaelKayumov RafaelKayumov Awaiting requested review from RafaelKayumov

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

category: tracks Related to analytics, including Tracks Events.

Projects

None yet

Milestone

24.2

Development

Successfully merging this pull request may close these issues.

3 participants

@adborbas @dangermattic @wpmobilebot