POS Bookings: Fix cash button offset and loading state for free orders#16719
Merged
POS Bookings: Fix cash button offset and loading state for free orders#16719
Conversation
The bookings fullscreen cover inherits the floatingControlAreaSize environment value from the dashboard, causing the cash payment view to add bottom padding for floating controls that aren't visible. Override the value to .zero in the bookings cover.
When a booking has a zero total, the card payment state stays idle and the reader stays connected, causing the "Loading order" spinner to show indefinitely. Pass isZeroTotal to skip the loading view for free orders.
Collaborator
|
|
Collaborator
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
iamgabrielma
approved these changes
Feb 24, 2026
Contributor
iamgabrielma
left a comment
There was a problem hiding this comment.
Verify the "Mark payment as complete" button is not offset from the bottom, as if floating controls were present.
Nice catch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes: WOOMOB-2262
Description
Two fixes for POS bookings payments:
Fix cash payment button offset — The bookings fullscreen cover inherits
floatingControlAreaSizefrom the dashboard, causing the collect cash view to add bottom padding for floating controls that aren't visible in bookings. This overrides the environment value to.zeroin the bookings cover.Skip "Loading order" for free bookings — When a booking has a zero total, the card payment state stays
.idleand the reader stays.connected, causing the "Loading order" spinner to show indefinitely. This skips the loading view whenisZeroTotalis true.Test Steps
Cash button offset:
Check the main payment flow as well – there, the button should still be offset from the buttons.
Free order loading:
You can only create a free, but "unpaid" booking in wp-admin – from the frontend, they're marked as paid by the checkout. It requires a free booking product. So... this is quite an edge case!
Note that the keyboard button on iOS 18 sometimes puts a small safearea when it's hidden, and sometimes doesn't. We respect that when the safearea's available.
Screenshots
payment-fixes.mp4
RELEASE-NOTES.txtif necessary.