Add Container Registry credential extension#5852
Add Container Registry credential extension#5852techknowlogick wants to merge 5 commits intowoodpecker-ci:mainfrom
Conversation
|
Why does the base registry take priority? Imho extension should be priority as they could be more specific |
fair, I've just updated it so extensions take priority (with repo taking precedence over global) |
|
Thanks! We also don't need the migration itself, model sync happens automatically. |
|
@qwerty287 sounds good. A habit of mine of struct changes in Gitea where any changes get a migration ;) As for UI I'm saving that for another PR since I wanted to validate the actual functionality first, and I'm more familiar with the backend code than the UI (so any changes needed I could implement much faster). I figured that for mvp it was fine to go with this route. |
|
Surge PR preview deployment was removed |
|
@techknowlogick can you fix the linter? https://ci.woodpecker-ci.org/repos/3780/pipeline/30254/35 LGTM otherwise. |
|
thanks @qwerty287, I've just sent lint fix :) |
|
Nice one! But can we add docs? 😬 |
|
Thanks for the work @techknowlogick again! I added UI and docs in #5993. |
|
@qwerty287 thanks to you too :) |
The configuration extension already exists, but this one would allow for dynamic addition of container registry credentials being injected into runs. That way you don't need to set static credentials in the database.
I might work on the secrets or environment variables extensions support next.