Skip to content

Do not spam git pull if something goes wrong#104

Merged
mhoffrog merged 1 commit intowoolfg:masterfrom
SqrtMinusOne:master
Mar 31, 2026
Merged

Do not spam git pull if something goes wrong#104
mhoffrog merged 1 commit intowoolfg:masterfrom
SqrtMinusOne:master

Conversation

@SqrtMinusOne
Copy link
Copy Markdown
Contributor

Currently, if an error occurs in git pull, lastpull.txt isn't updated, and the next git pull happens almost instantly.

As such I've had this happen on my setup:

  • git pull started erring out due to merge conflict
  • the plugin started running git pull several times a second
  • the entire server got blocked due to spamming similar requests.

This changes makes the plugin update lastpull.txt before git pull. Let me know if you can suggest a better fix.

@mhoffrog mhoffrog self-requested a review March 31, 2026 07:18
@mhoffrog
Copy link
Copy Markdown
Collaborator

@SqrtMinusOne Many THANKS for your contribution!

@mhoffrog mhoffrog merged commit 60a99fd into woolfg:master Mar 31, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants