-
Notifications
You must be signed in to change notification settings - Fork 5
[FEAT] 토큰 만료 시 웹소켓 재연결 및 메시지 재전송 처리 #1354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kimyou1102
wants to merge
6
commits into
develop
Choose a base branch
from
feature/1348-stomp-token-expiration-handler
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+65
−10
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
59ea507
feat: 스톰프 에러에서 토큰 만료 에러일 경우 재발급 요청 로직 추가 #1348
kimyou1102 9f15d22
feat: messageType 상수 추가 #1348
kimyou1102 2838f0c
feat: Message 타입에 messageType 속성 추가 #1348
kimyou1102 de28f71
feat: 재연결 시 pending 메시지 재전송 로직 구현 #1348
kimyou1102 29e864e
feat: 토큰 재발급 실패 시 에러 로그 추가 #1348
kimyou1102 2575604
refactor: onStompError 재발급 중복 방지 플래그를 let → useRef로 변경 #1348
kimyou1102 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| export const MESSAGE_TYPE = { | ||
| TEXT: 'TEXT', | ||
| IMAGE: 'IMAGE', | ||
| } as const; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p5: 혹시 pendingMessages가 있을 때만 메시지를 보낼 수 있도록 처리를 할 필요는 없을까요?
예를 들어 early return으로 메시지가 없을 경우엔 forEach문을 돌지 않게 만들어야 하는지 궁금합니다!