-
Notifications
You must be signed in to change notification settings - Fork 3
[feat] 북마크 콘텐츠 목록 화면 Compose 마이그레이션 #612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yrsel
wants to merge
27
commits into
develop
Choose a base branch
from
feature/#601
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
d720f51
feat: 북마크 콘텐츠 모두 보기 화면 UI 구현
yrsel dd12881
feat: 페이지네이션 도메인 레이어 구현
yrsel 1552621
feat: 페이지네이션 Ui/Presentation 레이어 구현
yrsel 5c00a16
feat: 북마크 콘텐츠 페이지네이션 API 데이터 영역 반환값 및 매퍼 수정
yrsel 5288e0d
feat: 콘텐츠 북마크 페이지네이션 로직 구현
yrsel 9c659ac
feat: 북마크 목록 콘텐츠와 마이페이지 북마크 콘텐츠 데이터 동기화
yrsel fd52d75
refactor: ktlintformat
yrsel 3b55f90
refactor: 북마크 콘텐츠 수 조회 API 연동
yrsel 748f514
refactor: 페이지네이션 API 내부 메서드 분리, 불필요한 어노테이션 제거
yrsel 3d3e99a
refactor: 코드래빗 반영
yrsel 0c7d1f6
refactor: 회원탈퇴 strings 띄어쓰기 수정
yrsel e83e6a8
Merge branch 'develop' of https://github.com/woowacourse-teams/2025-T…
yrsel 8df6919
refactor: 북마크 수 조회 함수 반환값 수정
yrsel 818d72c
refactor: BookmarkContentScreen 파라미터명에 on 접두사 추가
yrsel be984be
refactor: BookmarkContent 내부 컴포넌트들 공통에서 사용할 수 있도록 추출
yrsel 55a5c1d
refactor: bookmarks, accounts 복수형 패키지 이름 수정
yrsel a944888
refactor: 북마크 콘텐츠 목록 scaffold에 snackbarhost 추가
yrsel 2565a78
refactor: 북마크 콘텐츠 목록 modifier 수정
yrsel e5eb90e
refactor: 마이페이지의 북마크와 북마크 목록의 북마크, 구분할 수 있는 이름으로 수정
yrsel e8f2889
refactor: BookmarkContentList 람다 파라미터명 수정
yrsel 241b5ec
refactor: 북마크 목록 페이지네이션 threshold 값 조정
yrsel b1886c7
refactor: 북마크 콘텐츠 수 조회 API 에러에 대한 Preview 추가
yrsel 170643d
refactor: 북마크 목록 페이지네이션 더보기 에러에 대한 preview 추가
yrsel b1af884
refactor: 마이페이지 preview 추가
yrsel 6433fa9
refactor: ktlintformat
yrsel 4bb19d5
refactor: 코드래빗 리뷰 반영
yrsel 6fb2e7b
feat: 북마크 페이지네이션 파라미터 Cursor 객체 사용하도록 수정
yrsel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 0 additions & 6 deletions
6
android/app/src/main/java/com/on/turip/domain/bookmark/PagedBookmarkContents.kt
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
android/app/src/main/java/com/on/turip/domain/common/paging/Page.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| package com.on.turip.domain.common.paging | ||
|
|
||
| data class Page<T>( | ||
| val items: List<T>, | ||
| val hasNext: Boolean, | ||
| ) |
64 changes: 64 additions & 0 deletions
64
android/app/src/main/java/com/on/turip/ui/bookmarks/BookmarkContentActivity.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| package com.on.turip.ui.bookmarks | ||
|
|
||
| import android.app.Activity | ||
| import android.content.Context | ||
| import android.content.Intent | ||
| import android.os.Bundle | ||
| import androidx.activity.compose.setContent | ||
| import androidx.activity.enableEdgeToEdge | ||
| import androidx.appcompat.app.AppCompatActivity | ||
| import com.on.turip.ui.compose.bookmarks.BookmarkContentScreen | ||
| import com.on.turip.ui.compose.designsystem.theme.TuripTheme | ||
| import com.on.turip.ui.login.LoginActivity | ||
| import com.on.turip.ui.trip.TripDetailActivity | ||
| import dagger.hilt.android.AndroidEntryPoint | ||
|
|
||
| @AndroidEntryPoint | ||
| class BookmarkContentActivity : AppCompatActivity() { | ||
| private var hasBookmarkChanges = false | ||
|
|
||
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
| enableEdgeToEdge() | ||
|
|
||
| setContent { | ||
| TuripTheme { | ||
| BookmarkContentScreen( | ||
| navigateToBack = { | ||
| finish() | ||
| }, | ||
| navigateToLogin = { | ||
| val intent: Intent = | ||
| LoginActivity.newIntent(this).apply { | ||
| flags = | ||
| Intent.FLAG_ACTIVITY_NEW_TASK or Intent.FLAG_ACTIVITY_CLEAR_TASK | ||
| } | ||
| startActivity(intent) | ||
| finish() | ||
| }, | ||
| navigateToContent = { contentId: Long -> | ||
| val intent: Intent = | ||
| TripDetailActivity.newIntent(context = this, contentId = contentId) | ||
| startActivity(intent) | ||
| }, | ||
| onBookmarkChanged = { | ||
| hasBookmarkChanges = true | ||
| }, | ||
| ) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| override fun finish() { | ||
| val data = | ||
| Intent().apply { | ||
| putExtra("BOOKMARK_CONTENT_HAS_BOOKMARK_CHANGES_FLAG", hasBookmarkChanges) | ||
| } | ||
| setResult(Activity.RESULT_OK, data) | ||
| super.finish() | ||
| } | ||
|
|
||
| companion object { | ||
| fun newIntent(context: Context): Intent = Intent(context, BookmarkContentActivity::class.java) | ||
| } | ||
| } | ||
9 changes: 9 additions & 0 deletions
9
android/app/src/main/java/com/on/turip/ui/common/paging/PagingLoadMode.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| package com.on.turip.ui.common.paging | ||
|
|
||
| import androidx.compose.runtime.Immutable | ||
|
|
||
| @Immutable | ||
| enum class PagingLoadMode { | ||
| REFRESH, | ||
| APPEND, | ||
| } |
13 changes: 13 additions & 0 deletions
13
android/app/src/main/java/com/on/turip/ui/common/paging/PagingState.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| package com.on.turip.ui.common.paging | ||
|
|
||
| import androidx.compose.runtime.Immutable | ||
| import com.on.turip.ui.common.error.ErrorUiState | ||
| import kotlinx.collections.immutable.ImmutableList | ||
|
|
||
| @Immutable | ||
| data class PagingState<T>( | ||
| val items: ImmutableList<T>, | ||
| val hasNext: Boolean, | ||
| val isAppending: Boolean, | ||
| val errorUiState: ErrorUiState, | ||
| ) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.