Skip to content

Remove backend section and infrastructure diagram#1080

Open
2Jin1031 wants to merge 317 commits intodevelop-befrom
2Jin1031-patch-2
Open

Remove backend section and infrastructure diagram#1080
2Jin1031 wants to merge 317 commits intodevelop-befrom
2Jin1031-patch-2

Conversation

@2Jin1031
Copy link
Contributor

@2Jin1031 2Jin1031 commented Dec 28, 2025

Removed backend section and related infrastructure diagram from README.

πŸ”— κ΄€λ ¨ 이슈

  • close #{Issue Number}

πŸ“ μž‘μ—… λ‚΄μš©

μ£Όμš” 변경사항

πŸ“Έ μŠ€ν¬λ¦°μƒ· (Optional)

Summary by CodeRabbit

릴리슀 λ…ΈνŠΈ

  • λ¬Έμ„œν™”
    • λ°±μ—”λ“œ μ„Ήμ…˜μ˜ 인프라 λ‹€μ΄μ–΄κ·Έλž¨ ν•­λͺ©μ΄ μ œκ±°λ˜μ—ˆμŠ΅λ‹ˆλ‹€.

✏️ Tip: You can customize this high-level summary in your review settings.

junseo511 and others added 30 commits August 19, 2025 11:19
…5-mul-kkam into feat/511

# Conflicts:
#	android/app/src/main/java/com/mulkkam/ui/home/HomeFragment.kt
#	android/app/src/main/java/com/mulkkam/ui/home/HomeViewModel.kt
- CupCapacity 클래슀 이름을 CupAmount둜 λ³€κ²½ν–ˆμŠ΅λ‹ˆλ‹€.
- 이에 따라 ν•΄λ‹Ή 클래슀λ₯Ό μ‚¬μš©ν•˜λŠ” λͺ¨λ“  νŒŒμΌμ—μ„œ μ°Έμ‘°λ₯Ό μ—…λ°μ΄νŠΈν–ˆμŠ΅λ‹ˆλ‹€.
…mul-kkam into feat/601

# Conflicts:
#	android/app/src/main/AndroidManifest.xml
- ProgressWidgetWorkerμ—μ„œ LiveData λŒ€μ‹  Broadcastλ₯Ό μ‚¬μš©ν•˜μ—¬ μœ„μ ― μ—…λ°μ΄νŠΈ κ²°κ³Όλ₯Ό μ „λ‹¬ν•˜λ„λ‘ λ³€κ²½
…mul-kkam into feat/601

# Conflicts:
#	android/app/src/main/AndroidManifest.xml
#	android/app/src/main/java/com/mulkkam/ui/main/MainActivity.kt
#	android/app/src/main/java/com/mulkkam/ui/widget/ProgressWidget.kt
#	android/app/src/main/res/values/strings.xml
λ¬Ό μ„­μ·¨λŸ‰ μœ„μ ―μ— ν‘œμ‹œλ˜λŠ” μ»΅ μš©λŸ‰μ„ 첫 번째 컡이 μ•„λ‹Œ λŒ€ν‘œμ»΅(rankκ°€ 1인 μ»΅)의 μš©λŸ‰μœΌλ‘œ λ³€κ²½ν•©λ‹ˆλ‹€.
- `MulKkamUiState.Success` μƒνƒœμ—μ„œ 데이터λ₯Ό μΆ”μΆœν•˜λŠ” `toSuccessDataOrNull()` ν™•μž₯ ν•¨μˆ˜ μΆ”κ°€
- ν…ŒμŠ€νŠΈμš© `TodayProgressInfo`λ₯Ό μƒμ„±ν•˜λŠ” `createFakeSuccessProgressInfo()` ν•¨μˆ˜ μΆ”κ°€
junseo511 and others added 23 commits October 15, 2025 16:56
Co-authored-by: junseo511 <prime54@g.skku.edu>
Co-authored-by: GongBaek <127238018+junseo511@users.noreply.github.com>
Removed backend section and related infrastructure diagram from README.
@github-actions github-actions bot changed the base branch from main to develop-be December 28, 2025 08:07
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 28, 2025

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'tools'
βš™οΈ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

README.mdμ—μ„œ λ°±μ—”λ“œ μ„Ήμ…˜ μ•„λž˜μ˜ "인프라 λ‹€μ΄μ–΄κ·Έλž¨" μ„œλΈŒμ„Ήμ…˜ 전체가 μ œκ±°λ˜μ—ˆμŠ΅λ‹ˆλ‹€. 헀더, 이미지 μ°Έμ‘°, κ΄€λ ¨ 곡백이 μ‚­μ œλ˜μ—ˆμœΌλ©°, λ¬Έμ„œμ˜ λ‚˜λ¨Έμ§€ λ‚΄μš©μ€ μœ μ§€λ˜μ—ˆμŠ΅λ‹ˆλ‹€.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

κ²€ν†  μ‹œ 고렀사항

이번 변경은 λ¬Έμ„œ μ‚­μ œμ— ν•΄λ‹Ήν•˜λŠ”λ°, λͺ‡ κ°€μ§€ μ§šμ–΄λ³Ό 뢀뢄이 μžˆμŠ΅λ‹ˆλ‹€.

잠재적 고렀사항:
인프라 λ‹€μ΄μ–΄κ·Έλž¨μ΄ 제거된 μ΄μœ κ°€ λͺ…ν™•ν•˜μ§€ μ•ŠμŠ΅λ‹ˆλ‹€. λ‹¨μˆœνžˆ 였래된 μ •λ³΄μ—¬μ„œ μ œκ±°ν•˜λŠ” 것인지, μž„μ‹œλ‘œ μˆ¨κΈ°λ €λŠ” 것인지, μ•„λ‹ˆλ©΄ λ‹€λ₯Έ μœ„μΉ˜λ‘œ 이동 μ˜ˆμ •μΈμ§€μ— 따라 접근이 λ‹¬λΌμ§ˆ 수 μžˆμŠ΅λ‹ˆλ‹€.

κ°œμ„  λ°©ν–₯ κ²€ν† :

  1. λ¬Έμ„œ 일관성 확인 β€” λ‹€λ₯Έ μ„Ήμ…˜(ν”„λ‘ νŠΈμ—”λ“œ, DB λ“±)에도 μœ μ‚¬ν•œ λ‹€μ΄μ–΄κ·Έλž¨μ΄ μžˆλ‹€λ©΄, 전체 λ¬Έμ„œ ꡬ쑰의 κ· ν˜•μ„ κ³ λ €ν•˜μ…”μ•Ό ν•©λ‹ˆλ‹€.

  2. λŒ€μ•ˆ 비ꡐ:

    • μ™„μ „ μ‚­μ œ (ν˜„μž¬ 방식): κ°„κ²°ν•˜μ§€λ§Œ λ‚˜μ€‘μ— ν•„μš”ν•  λ•Œ 컀밋 이λ ₯을 λ’€μ Έμ•Ό 함
    • μ£Όμ„μ²˜λ¦¬: <!--둜 κ°μ‹Έμ„œ μœ μ§€ν•˜λ©΄ ν–₯ν›„ 볡ꡬ가 μš©μ΄ν•¨
    • 별도 λ¬Έμ„œλ‘œ 이동: ꡬ식 인프라 정보라면 λ³„λ„μ˜ μ•„μΉ΄μ΄λΈŒ λ¬Έμ„œλ‘œ μ •λ¦¬ν•˜λŠ” 방식도 있음

ꢌμž₯사항: μ‚­μ œ 전에 이 λ‹€μ΄μ–΄κ·Έλž¨μ΄ 정말 더 이상 ν•„μš” μ—†λŠ”μ§€, λ˜λŠ” λ‚˜μ€‘μ— μ°Έκ³ ν•  κ°€λŠ₯성이 μžˆλŠ”μ§€ νŒ€κ³Ό ν™•μΈν•˜μ‹  ν›„ μ§„ν–‰ν•˜μ‹œλŠ” 것이 μ’‹μŠ΅λ‹ˆλ‹€.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning μ„€λͺ…이 λ³€κ²½ 사항을 μš”μ•½ν–ˆμœΌλ‚˜, ν…œν”Œλ¦Ώμ˜ ν•„μˆ˜ μ„Ήμ…˜λ“€μ΄ λŒ€λΆ€λΆ„ μ±„μ›Œμ§€μ§€ μ•Šμ€ μƒνƒœμž…λ‹ˆλ‹€. κ΄€λ ¨ 이슈 번호λ₯Ό λͺ…μ‹œν•˜κ³ , μž‘μ—… λ‚΄μš©κ³Ό μ£Όμš” 변경사항 μ„Ήμ…˜μ— ꡬ체적인 λ‚΄μš©μ„ μž‘μ„±ν•΄μ£Όμ„Έμš”.
βœ… Passed checks (2 passed)
Check name Status Explanation
Title check βœ… Passed 제λͺ©μ΄ READMEμ—μ„œ λ°±μ—”λ“œ μ„Ήμ…˜κ³Ό 인프라 λ‹€μ΄μ–΄κ·Έλž¨μ„ μ œκ±°ν•œ μ£Όμš” λ³€κ²½ 사항을 λͺ…ν™•ν•˜κ²Œ λ°˜μ˜ν•˜κ³  μžˆμŠ΅λ‹ˆλ‹€.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 2Jin1031-patch-2

πŸ“œ Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 9bb8835 and 29d5e37.

πŸ“’ Files selected for processing (1)
  • README.md
πŸ’€ Files with no reviewable changes (1)
  • README.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the BE λ°±μ—”λ“œ κ΄€λ ¨ μ΄μŠˆμž…λ‹ˆλ‹€. label Dec 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BE λ°±μ—”λ“œ κ΄€λ ¨ μ΄μŠˆμž…λ‹ˆλ‹€.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants