Open
Conversation
There was a problem hiding this comment.
Pull request overview
입장 닉네임 입력 화면에서 닉네임 자동 생성(랜덤 닉네임) 기능을 제공하고, 닉네임 검증(비속어 등) 실패 시 토스트 기반 에러 노출이 가능하도록 개선한 PR입니다. (#1123)
Changes:
- EntryNamePage에 랜덤 닉네임 생성 버튼 추가 및 랜덤 닉네임 API 호출 로직 추가
- 닉네임 중복 체크/랜덤 닉네임 요청에
errorDisplayMode: 'toast'적용 - 공용
RefreshIcon컴포넌트 신규 추가 및 관련 스타일 추가
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| frontend/src/features/entry/pages/EntryNamePage/EntryNamePage.tsx | 랜덤 닉네임 호출/버튼 UI 추가, 토스트 에러 모드 적용 |
| frontend/src/features/entry/pages/EntryNamePage/EntryNamePage.styled.ts | 헤더 행/랜덤 생성 버튼 스타일 추가 |
| frontend/src/components/@common/RefreshIcon/RefreshIcon.tsx | 랜덤 생성 버튼에서 사용할 새 아이콘 컴포넌트 추가 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
frontend/src/features/entry/pages/EntryNamePage/EntryNamePage.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+38
to
+44
| const { execute: checkGuestName } = useLazyFetch<PlayerNameCheckResponse>({ | ||
| endpoint: `/rooms/check-guestName?joinCode=${joinCode}&guestName=${name}`, | ||
| errorDisplayMode: 'toast', | ||
| }); | ||
|
|
||
| const randomNicknameEndpoint = joinCode | ||
| ? `/rooms/nickname/random?joinCode=${joinCode}` |
frontend/src/features/entry/pages/EntryNamePage/EntryNamePage.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ 체크리스트
🔥 연관 이슈
🚀 작업 내용
💬 리뷰 중점사항
중점사항