[Tooling] Improve Prototype (aka Installable) Build comment and metadata #17926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
AliSoftware
force-pushed
the
tooling/prototype-build-metadata
branch
from
993507c to
9d4b54b
Compare
AliSoftware
force-pushed
the
tooling/prototype-build-metadata
branch
from
9d4b54b to
fb102ea
Compare
AliSoftware
force-pushed
the
tooling/prototype-build-metadata
branch
from
fb102ea to
09ea28a
Compare
Contributor
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr17926-063d16c | |
| Commit | 063d16c | |
| Direct Download | jetpack-prototype-build-pr17926-063d16c.apk |
Contributor
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr17926-063d16c | |
| Commit | 063d16c | |
| Direct Download | wordpress-prototype-build-pr17926-063d16c.apk |
Generated by 🚫 dangerJS |
ParaskP7
approved these changes
Mar 13, 2023
Contributor
ParaskP7
left a comment
ParaskP7
left a comment
There was a problem hiding this comment.
👋 @AliSoftware !
I have reviewed and tested this PR as per the instructions, everything works as expected, good job replacing our custom comment configuration with prototype_build_details_comment(...)! 🌟 🌟 🌟
- Check that the PR got two PR comments, providing the information for the WordPress and Jetpack Prototype builds respectively, and verify that the information about those builds displayed in the table is accurate
- Scan the QR code (and/or follow the URL) and validate that it directly redirects you to download the APK and successfully allows you to install that APK on your test device. Repeat for each app (WP/JP)
- Open the page for the last Buildkite build for this PR and validate that there are 2 annotations (one for WP, one for JP) containing the link to download the Prototype Build APK
- Add
/meta-dataat the end of the URL of that last Buildkite build (e.g. like this) and validate that the metadata attached to the build are correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to wordpress-mobile/WordPress-iOS#20071
What?
Improve Prototype (aka Installable) Builds in a couple of ways:
To test:
/meta-dataat the end of the URL of that last Buildkite build (e.g. like this) and validate that the metadata attached to the build are correct.