Skip to content

feat: Introduce gutenberg_kit editor session property#21564

Merged
nbradbury merged 1 commit intotrunkfrom
feat/improve-editor-session-event-properties
Jan 7, 2025
Merged

feat: Introduce gutenberg_kit editor session property#21564
nbradbury merged 1 commit intotrunkfrom
feat/improve-editor-session-event-properties

Conversation

@dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Jan 7, 2025

Enable analysis of editor sessions utilizing GutenbergKit.

Related:

To Test:

  1. Launch the experimental editor.
  2. Close the editor.
  3. Verify editor_session_start|end events trigger with an editor: gutenberg_kit property value.

Regression Notes

  1. Potential unintended areas of impact
    Disruption to events within other text editors.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Verified the editor session events continue working as expected.
  3. What automated tests I added (or what prevented me from doing so)
    Deemed unnecessary for this experimental editor analytic event.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

Enable analysis of editor sessions utilizing GutenbergKit.
@dcalhoun dcalhoun added [Type] Enhancement Gutenberg Editing and display of Gutenberg blocks. labels Jan 7, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Jan 7, 2025

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21564-12fa0d8
Commit12fa0d8
Direct Downloadwordpress-prototype-build-pr21564-12fa0d8.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21564-12fa0d8
Commit12fa0d8
Direct Downloadjetpack-prototype-build-pr21564-12fa0d8.apk
Note: Google Login is not supported on these builds.

@codecov
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.48%. Comparing base (108babf) to head (12fa0d8).
Report is 2 commits behind head on trunk.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #21564   +/-   ##
=======================================
  Coverage   39.48%   39.48%           
=======================================
  Files        2117     2117           
  Lines       99464    99464           
  Branches    15296    15296           
=======================================
  Hits        39269    39269           
  Misses      56714    56714           
  Partials     3481     3481           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dcalhoun dcalhoun marked this pull request as ready for review January 7, 2025 18:56
@dcalhoun dcalhoun requested a review from nbradbury January 7, 2025 18:58
@nbradbury nbradbury self-assigned this Jan 7, 2025
Copy link
Contributor

@nbradbury nbradbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good! :shipit:

@nbradbury nbradbury merged commit eb664ba into trunk Jan 7, 2025
26 checks passed
@nbradbury nbradbury deleted the feat/improve-editor-session-event-properties branch January 7, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Editing and display of Gutenberg blocks. [Type] Enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants