-
Notifications
You must be signed in to change notification settings - Fork 1.4k
CMM-886 logs sharing fix and send to he ticket #22337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adalpari
wants to merge
185
commits into
trunk
Choose a base branch
from
feat/CMM-886-create-logs-sharing-with-HE
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+594
−398
Open
Changes from 178 commits
Commits
Show all changes
185 commits
Select commit
Hold shift + click to select a range
80d4ed3
Adding basic UI
adalpari 4836d41
Renaming
adalpari 37541d0
Some styling
adalpari 51b01a7
Renaming and dummy data
adalpari 6c83ae3
Using proper "new conversation icon"
adalpari 8d7ea50
Conversation details screen
adalpari a0a146b
Creating the reply bottomsheet
adalpari eebc0ab
Linking to the support screen
adalpari 37676c8
bottomsheet fix
adalpari 703f4c4
Mov navigation form activity to viewmodel
adalpari f6be7fd
Adding create ticket screen
adalpari d345864
More screen adjustments
adalpari 05773ec
Extracting common code
adalpari b442787
Margin fix
adalpari cf4762e
detekt
adalpari 7d318b1
Style
adalpari 1ab8f3b
Merge branch 'trunk' into feat/CMM-843-Create-the-Ask-the-HE-entry-UI
adalpari d585a4a
New ticket check
adalpari 8c651fc
Creating tests
adalpari fdf926b
Merge branch 'feat/CMM-843-Create-the-Ask-the-HE-entry-UI' of https:/…
adalpari 3515fd0
Creating repository and load conversations function
adalpari 3d99919
Adding createConversation function
adalpari 0be28b4
Creating loadConversation func
adalpari 40a5880
Loading conversations form the viewmodel
adalpari a55994e
Adding loading spinner
adalpari c82458c
Pull to refresh
adalpari 73a434a
Proper ionitialization
adalpari 087d07a
Adding empty screen
adalpari 3b5a1e5
Handling send new conversation
adalpari 4febc3d
Show loading when sending
adalpari e1215a9
New ticket creation fix
adalpari 98cbb1f
Using snackbar for errors
adalpari 5d421d3
Error handling
adalpari af8e1dd
Answering conversation
adalpari cad1eec
Adding some test to the repository
adalpari 481ae11
More tests!
adalpari 4e0b242
Merge branch 'trunk' into feat/CMM-872-support-HE-conversations-and-t…
adalpari 95c80bd
Compile fixes
adalpari d36882e
Similarities improvements
adalpari 563f58b
Using snackbar in bots activity
adalpari ab8ca28
Extracting EmptyConversationsView
adalpari 034288e
Renaming
adalpari 049df3e
Extracting VM and UI common code
adalpari 15ab84e
Extracting navigation common code
adalpari 53085d0
Renaming VMs for clarification
adalpari 8c057bf
More refactor
adalpari a4ed792
Capitalise text fields
adalpari ccef4b7
Updating rs library
adalpari be6a5f2
Loading conversation UX
adalpari f023bf8
Style fix
adalpari d33e512
Fixing scaffolds paddings
adalpari ca5af7a
userID fix
adalpari 972641d
Fixing the padding problem in bot chat when the keyboard is opened
adalpari d328103
Apply padding to create ticket screen when the keyboard is opened
adalpari 4501d9a
Fixing scroll state in reply bottomsheet
adalpari c2baa18
Adding tests for the new common viewmodel
adalpari 6aa8de1
Fixing AIBotSupportViewModel tests
adalpari 204afef
detekt
adalpari a304d67
Improvements int he conversation interaction
adalpari 6ee853b
Adding tests for HE VM
adalpari d0a549c
Merge branch 'trunk' into feat/CMM-872-support-HE-conversations-and-t…
adalpari bc476a7
Merge remote-tracking branch 'origin/trunk' into feat/CMM-872-support…
adalpari a13ae5b
Saving draft state
adalpari 49f1af3
Properly navigating when a ticket is selected
adalpari e394c7a
Error parsing improvement
adalpari a6c421c
accessToken suggestion improvements
adalpari dbcb453
General suggestions
adalpari 03f00fe
Send message error UX improvement
adalpari c117fcf
Fixing tests
adalpari d40d1d2
Converting the UI to more AndroidMaterial style
adalpari d318c2d
Bots screen renaming
adalpari c12f0fd
Bots screens renaming
adalpari 1466115
Merge branch 'feat/CMM-872-support-HE-conversations-and-tickets-logic…
adalpari 1d4a490
Make NewTicket screen more Android Material theme as well
adalpari 7232fb2
Adding preview for EmptyConversationsView
adalpari a6e3e65
Button fix
adalpari 19fcdf6
detekt
adalpari c41d801
Merge branch 'trunk' into feat/CMM-884-support-Iterate-over-the-whole…
adalpari 6ddffcf
Ticket selection change
adalpari 30fb83f
Supporting markdown text
adalpari 3f908f2
detekt
adalpari 1f6f555
Improving MarkdownUtils
adalpari 727644c
Formatting text in the repository layer instead the ui
adalpari 3eb939c
Renaming
adalpari 455c100
Fixing tests
adalpari a07d01c
Support pagination
adalpari b8fe4af
Triggering in the 4th element
adalpari 0ef0205
detekt
adalpari 836f3dd
TODO for debug purposes
adalpari e126063
Claude PR suggestions
adalpari ce8deba
Put ConversationListView in common between bots and HE
adalpari fa2f147
Empty and error state
adalpari 971499a
Skip site capitalization
adalpari 6ecf89d
Adding a11c labels
adalpari 3edc398
Adding headings labels
adalpari ded3f34
adding accessible labels to chat bubbles
adalpari d8c4468
detekt
adalpari f97d4e8
Fixing tests
adalpari 1294e3d
PR suggestion about bot chat bubble
adalpari f8dc40e
Fixing tests
adalpari 983ea0d
Updating rust
adalpari 471312e
Adding attachments UI
adalpari 4744542
Parsing markdown more exhaustively
adalpari ce4641f
New links support
adalpari 55d37a5
Detekt
adalpari 8314472
Supporting in conversation as well
adalpari af50df5
Keeping the screen when select images
adalpari 8223d9e
Add attachments to the message data class
adalpari 2b75327
Showing attachments in the UI
adalpari 49082a2
Downloading attachments
adalpari 6e93ffd
detekt
adalpari 1c6300d
Support pagination
adalpari 53ec089
Triggering in the 4th element
adalpari 7370761
detekt
adalpari 7bd8919
TODO for debug purposes
adalpari 9016a82
Claude PR suggestions
adalpari 88fc5d2
Detekt
adalpari 3d1ab98
Merge branch 'feat/CMM-883-support-Oddie-bot-conversation-pagination'…
adalpari d8affd9
Removing testing code
adalpari 260ded1
Updating RS library version
adalpari 109cc41
Opening images in fullscreen
adalpari 0d782f0
Improving full screen image UX
adalpari e0d2955
Merge branch 'feat/CMM-883-support-Oddie-bot-conversation-pagination'…
adalpari f15af11
Improving semantics
adalpari c39e5ca
Merge branch 'trunk' into feat/CMM-885-support-HE-attachments
adalpari 81d6d28
Extracting strings
adalpari 5c31d48
Using rs PR fix
adalpari 0f67996
Showing attachment preview
adalpari 3343a03
Clearing attachments on new ticket screen close
adalpari f3e40c9
Removing selected images limit
adalpari ad1382a
Unifying attachments handling inside the VM
adalpari 5dd1432
Using a launcher instead of startActivityForResult
adalpari 72bad43
Remove unused parameter
adalpari f7795db
Handling temp files inside the VM
adalpari 94bb5d8
Removing files
adalpari 5a51b11
detekt
adalpari d1a9aaf
Throwing copy file error
adalpari 310d9df
Extracting some individual composables from HEConversation screen file
adalpari 09f138a
Reducing arguments
adalpari b0ebf82
Catch file creation error
adalpari 848235f
Using proper file extension
adalpari 9a502b2
General improvements
adalpari 9f5ec65
Update RS version and some fixes
adalpari ce18ff0
Extracting temp attachment utils
adalpari 9903bfb
Adding new tests
adalpari 9ac2bd9
Some refactoring
adalpari c197b7c
Merge branch 'trunk' into feat/CMM-885-support-HE-attachments
adalpari 9871cd8
Merge remote-tracking branch 'origin/trunk' into feat/CMM-885-support…
adalpari 6daee20
Removing attachments preview to open a dedicated PR
adalpari 3687944
Useless changes
adalpari 529123f
Useless changes
adalpari 602b014
Minor refactor
adalpari 7890c15
Showing attachments previews
adalpari bbe0ae7
Typo
adalpari e65b8cc
String fix
adalpari eb02a33
Fixing pan issue
adalpari 900cdaf
Passing attachments directly instead of searching for then when tappe…
adalpari 2a4ac16
Merge branch 'feat/CMM-885-support-HE-attachments' into feat/CMM-885-…
adalpari 315083a
Compile fix
adalpari 96709f6
Uploading logs
adalpari 9a5fb5b
Uploading logs in the current way
adalpari 7baacd2
Linking UI with the new logs upload methods
adalpari d50051c
Merge branch 'trunk' into feat/CMM-886-create-logs-sharing-with-HE
adalpari 4081ef0
Detekt
adalpari a40b686
Merge branch 'trunk' into feat/CMM-886-create-logs-sharing-with-HE
adalpari 97426a3
Including logs in new conversations
adalpari 31733ef
Merge branch 'trunk' into feat/CMM-886-create-logs-sharing-with-HE
adalpari 4df31a9
updating wp-rs
adalpari 181b822
Using LogFiles for logs entries
adalpari 3b0e5a5
Uploading all files
adalpari 6ed850a
Sharing the whole file
adalpari 4c99ede
Fixing tests
adalpari 5ee499b
detekt
adalpari 90c7e39
Merge remote-tracking branch 'origin/trunk' into feat/CMM-886-create-…
adalpari a19074f
Merge branch 'trunk' into feat/CMM-886-create-logs-sharing-with-HE
adalpari 7c5992c
Test fix
adalpari eedc306
Some small fixes
adalpari 4d0ac02
Merge branch 'trunk' into feat/CMM-886-create-logs-sharing-with-HE
adalpari 012f678
Renaming and logging
adalpari adaf808
Clearing temp folder oncleared
adalpari c7f6838
detekt
adalpari 100740b
Merge branch 'feat/CMM-886-create-logs-sharing-with-HE' of https://gi…
adalpari a21da6c
typo
adalpari 349cb32
Test compile fix
adalpari 2c89119
test fix
adalpari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -70,6 +70,7 @@ fun HENewTicketScreen( | |
| subject: String, | ||
| messageText: String, | ||
| siteAddress: String, | ||
| includeAppLogs: Boolean, | ||
| ) -> Unit, | ||
| userInfo: UserInfo, | ||
| isSendingNewConversation: Boolean = false, | ||
|
|
@@ -110,8 +111,9 @@ private fun HENewTicketScreenContent( | |
| onSubmit: ( | ||
| category: SupportCategory, | ||
| subject: String, | ||
| messageText: String, | ||
| message: String, | ||
| siteAddress: String, | ||
| includeAppLogs: Boolean, | ||
| ) -> Unit, | ||
| userInfo: UserInfo, | ||
| isSendingNewConversation: Boolean, | ||
|
|
@@ -143,7 +145,7 @@ private fun HENewTicketScreenContent( | |
| isLoading = isSendingNewConversation, | ||
| onClick = { | ||
| selectedCategory?.let { category -> | ||
| onSubmit(category, subject, messageText, siteAddress) | ||
| onSubmit(category, subject, messageText, siteAddress, includeAppLogs) | ||
| } | ||
| } | ||
| ) | ||
|
|
@@ -465,7 +467,7 @@ private fun HENewTicketScreenPreviewContent(snackbarHostState: SnackbarHostState | |
| HENewTicketScreenContent( | ||
| snackbarHostState = snackbarHostState, | ||
| onBackClick = { }, | ||
| onSubmit = { _, _, _, _ -> }, | ||
| onSubmit = { _, _, _, _, _ -> }, | ||
| userInfo = UserInfo("Test user", "[email protected]", null), | ||
| isSendingNewConversation = false, | ||
| attachmentState = AttachmentState(), | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 0 additions & 8 deletions
8
WordPress/src/main/java/org/wordpress/android/support/logs/model/LogDay.kt
This file was deleted.
Oops, something went wrong.
12 changes: 12 additions & 0 deletions
12
WordPress/src/main/java/org/wordpress/android/support/logs/model/LogFile.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| package org.wordpress.android.support.logs.model | ||
|
|
||
| import java.io.File | ||
|
|
||
| data class LogFile( | ||
| val file: File, | ||
| val fileName: String, | ||
| val title: String, | ||
| val subtitle: String, | ||
| // Log lines could be truncated to avoid memory issues | ||
| val logLines: List<String>? = null | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.