Remove navigation menus experimental feature flag#22582
Merged
Conversation
- Remove NAV_MENUS from ExperimentalFeatures enum - Enable navigation menus for all users with application password and edit theme options capability - Add BETA badge to Menus item in My Site list - Add showBetaBadge property to ListItem data class Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
Generated by 🚫 Danger |
Contributor
|
|
Contributor
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #22582 +/- ##
==========================================
- Coverage 38.18% 38.18% -0.01%
==========================================
Files 2238 2238
Lines 111779 111776 -3
Branches 15587 15586 -1
==========================================
- Hits 42680 42677 -3
Misses 65558 65558
Partials 3541 3541 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add verticalScroll modifier to the main Column so the screen scrolls when content overflows on smaller displays. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
dcalhoun
added a commit
that referenced
this pull request
Feb 20, 2026
Restore the horizontal constraint chain in my_site_item_block.xml that was broken when adding beta badge support (#22582, #22593). Without the chain, ConstraintLayout ignored the icon-to-text marginEnd. Fix quick_link_item.xml spacing after the MaterialButton-to-manual-views conversion: move icon-to-text gap from marginEnd on the icon (ignored without an End constraint) to marginStart on the label, restore the original 8dp horizontal padding, and add vertical padding to match the MaterialButton's inset+padding behavior.
8 tasks
dcalhoun
added a commit
that referenced
this pull request
Feb 20, 2026
* fix: Restore spacing in My Site menu items and quick link items Restore the horizontal constraint chain in my_site_item_block.xml that was broken when adding beta badge support (#22582, #22593). Without the chain, ConstraintLayout ignored the icon-to-text marginEnd. Fix quick_link_item.xml spacing after the MaterialButton-to-manual-views conversion: move icon-to-text gap from marginEnd on the icon (ignored without an End constraint) to marginStart on the label, restore the original 8dp horizontal padding, and add vertical padding to match the MaterialButton's inset+padding behavior. * fix: Announce My Site navigation items as buttons for screen readers The MaterialButton-to-manual-views conversion lost the button accessibility role. Set the className to Button via an AccessibilityDelegateCompat so TalkBack announces these items as buttons again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Partially addresses CMM-1166 by removing the experimental feature flag for navigation menus, making the feature available to all users who have:
Also adds a BETA badge to the Menus item in the My Site list to indicate the feature is still in beta.
This PR also includes a fix for the experimental features screen which previously wasn't scrollable.
Changes
NAV_MENUSfromExperimentalFeaturesenumbuildMenusItemIfAvailable()showBetaBadgeproperty toListItemdata classTesting instructions